mz817: expand variables in COPY/ADD heredoc content#821
Open
mzihlmann wants to merge 3 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
mzihlmann
force-pushed
the
mz817-copy-heredoc-expansion
branch
2 times, most recently
from
6e51cb9 to
4d3b350
Compare
mzihlmann
force-pushed
the
mz817-copy-heredoc-expansion
branch
from
4d3b350 to
737f5d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #817
A COPY or ADD heredoc with an unquoted delimiter now expands build args and env into its body like docker does, expanding
${VAR}and stripping the backslash from\${VAR}. Kaniko wrote the body verbatim before, so variables ended up in the file literally.Quote the delimiter to keep the body verbatim and get the old behaviour:
COPY <<'EOF'leaves${VAR}untouched.