Skip to content

NO ISSUE: add cross-component proto trigger to check-generated-code #527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
redhat-chai-bot wants to merge 1 commit into from
Closed

NO ISSUE: add cross-component proto trigger to check-generated-code #527

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/check-generated-code.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ jobs:
- '!fulfillment-service/**/*.md'
- '!fulfillment-service/docs/**'
osac-operator:
- 'osac-operator/**'
- '{osac-operator,fulfillment-service/proto}/**'
- '!osac-operator/OWNERS'
- '!osac-operator/LICENSE'

@fullsend-ai-review fullsend-ai-review Bot Aug 26, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[low] scope-precision

The filter uses fulfillment-service/proto/** which is broader than the actual input directory fulfillment-service/proto/private referenced by buf.gen.yaml. Changes to other subdirectories under fulfillment-service/proto/ would trigger an unnecessary osac-operator check. This is a minor over-trigger (safer direction) rather than a coverage gap.

- '!osac-operator/**/*.md'
Expand Down
Loading