Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion osac-aap/execution-environment/requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ autopage==0.6.0
# via cliff
babel==2.18.0
# via python-esiclient
boto3==1.43.56
boto3==1.43.78
# via osac-aap (pyproject.toml)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[high] dependency version mismatch

boto3 is bumped to 1.43.75 but botocore remains pinned at 1.43.56. boto3 1.43.75 requires botocore>=1.43.75,<1.44.0. The lockfile now contains an unsatisfiable constraint that will cause a pip install failure or, if --no-deps is used, runtime errors from API mismatches between the two libraries.

Suggested fix: Re-run the lockfile generator (uv pip compile pyproject.toml --python-version 3.12 -o execution-environment/requirements.txt) so that botocore is bumped to the version required by boto3 1.43.75 (at least 1.43.75).

botocore==1.43.56

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[critical] dependency version mismatch

boto3 is bumped to 1.43.76 but botocore remains pinned at 1.43.56. boto3==1.43.76 requires botocore>=1.43.76,<1.44.0 (confirmed via boto3 1.43.76 setup.py on GitHub). botocore==1.43.56 does not satisfy >=1.43.76, so pip/uv will fail to resolve dependencies at install time, breaking the execution environment build.

Suggested fix: Bump botocore from 1.43.56 to 1.43.76 on line 32, or re-run uv pip compile to regenerate the lockfile so that botocore is updated to match boto3.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[high] dependency version mismatch

boto3 was bumped to 1.43.77 but botocore remains pinned at 1.43.56. boto3 1.43.77 requires botocore>=1.43.77,<1.44.0, which botocore==1.43.56 does not satisfy. Furthermore, aiobotocore==3.9.0 (also in this lockfile) requires botocore>=1.43.3,<1.43.57, meaning boto3 1.43.77 and aiobotocore 3.9.0 have mutually exclusive botocore version requirements. This lockfile is internally inconsistent and would fail a strict pip install.

Suggested fix: Re-run uv pip compile to regenerate the lockfile. The resolver will either bump both botocore and aiobotocore to compatible versions, or report the conflict so it can be resolved in pyproject.toml. Simply bumping botocore to 1.43.77 alone would break aiobotocore 3.9.0.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[high] dependency version mismatch

boto3 was bumped to 1.43.78 but botocore remains pinned at 1.43.56. boto3 1.43.78 requires botocore>=1.43.78,<1.44.0, so botocore 1.43.56 does not satisfy the constraint. Furthermore, aiobotocore 3.9.0 (also in this lockfile) requires botocore>=1.43.3,<1.43.57, making it impossible to satisfy both boto3 1.43.78 and aiobotocore 3.9.0 simultaneously β€” their botocore ranges are disjoint. This file was generated by uv pip compile, so the root cause is likely that boto3 was bumped in pyproject.toml without re-running the compiler, or the bot only updated one line in the lockfile without regenerating.

Suggested fix: Re-run uv pip compile pyproject.toml --python-version 3.12 -o execution-environment/requirements.txt to let the resolver find a consistent solution. If boto3 1.43.78 truly cannot coexist with the current aiobotocore pin, either (a) bump aiobotocore to a version compatible with botocore >=1.43.78, or (b) keep boto3 at the older version compatible with aiobotocore 3.9.0 botocore ceiling (<1.43.57). Do not manually edit individual pins in a compiler-generated lockfile.

# via
Expand Down
Loading