-
Notifications
You must be signed in to change notification settings - Fork 76
OSAC-3385: Add role bindings management UI with list, create, edit, a… #132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,84 @@ | ||
| import { type MessageInitShape } from '@bufbuild/protobuf'; | ||
| import { useMutation } from '@tanstack/react-query'; | ||
|
|
||
| import { type RoleBindingSchema, RoleBindings } from '@osac/types'; | ||
|
|
||
| import { useApiFetch } from '../api-context'; | ||
| import { type ListParams, apiQueryKey } from '../types'; | ||
| import { type ApiQueryClient, useApiQuery, useApiQueryClient } from '../use-api-query'; | ||
| import { buildUpdateMaskPaths } from './update-mask'; | ||
|
|
||
| const invalidateRoleBindingQueries = (qc: ApiQueryClient) => | ||
| qc.invalidateQueries({ queryKey: apiQueryKey('v1/role_bindings') }); | ||
|
|
||
| export const useRoleBindings = (params: ListParams = {}) => { | ||
| const client = useApiFetch(RoleBindings); | ||
| return useApiQuery({ | ||
| queryKey: apiQueryKey('v1/role_bindings', undefined, params), | ||
| queryFn: () => client.list(params), | ||
| select: (data) => data.items, | ||
| }); | ||
| }; | ||
|
|
||
| export const useRoleBinding = (id?: string) => { | ||
| const client = useApiFetch(RoleBindings); | ||
| return useApiQuery({ | ||
| queryKey: apiQueryKey('v1/role_bindings', [id]), | ||
| queryFn: () => client.get({ id }), | ||
| select: (data) => data.object, | ||
| enabled: !!id, | ||
| }); | ||
| }; | ||
|
|
||
| export const useCreateRoleBinding = () => { | ||
| const client = useApiFetch(RoleBindings); | ||
| const qc = useApiQueryClient(); | ||
| return useMutation({ | ||
| mutationFn: async (body: MessageInitShape<typeof RoleBindingSchema>) => { | ||
| const resp = await client.create({ object: body }); | ||
| if (!resp.object) { | ||
| throw new Error('Create response missing role binding object'); | ||
| } | ||
| return resp.object; | ||
| }, | ||
| onSuccess: () => invalidateRoleBindingQueries(qc), | ||
| }); | ||
| }; | ||
|
|
||
| export const useUpdateRoleBinding = () => { | ||
| const client = useApiFetch(RoleBindings); | ||
| const qc = useApiQueryClient(); | ||
| return useMutation({ | ||
| mutationFn: async ({ | ||
| id, | ||
| body, | ||
| }: { | ||
| id: string; | ||
| body: MessageInitShape<typeof RoleBindingSchema>; | ||
| }) => { | ||
| const resp = await client.update({ | ||
| object: { | ||
| id, | ||
| ...body, | ||
| }, | ||
| updateMask: { | ||
| paths: buildUpdateMaskPaths(body), | ||
| }, | ||
| }); | ||
| if (!resp.object) { | ||
| throw new Error('Update response missing role binding object'); | ||
| } | ||
| return resp.object; | ||
| }, | ||
| onSuccess: () => invalidateRoleBindingQueries(qc), | ||
| }); | ||
| }; | ||
|
|
||
| export const useDeleteRoleBinding = () => { | ||
| const client = useApiFetch(RoleBindings); | ||
| const qc = useApiQueryClient(); | ||
| return useMutation({ | ||
| mutationFn: (id: string) => client.delete({ id }), | ||
| onSuccess: () => invalidateRoleBindingQueries(qc), | ||
| }); | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| import { Roles } from '@osac/types'; | ||
|
|
||
| import { useApiFetch } from '../api-context'; | ||
| import { type ListParams, apiQueryKey } from '../types'; | ||
| import { useApiQuery } from '../use-api-query'; | ||
|
|
||
| export const useRoles = (params: ListParams = {}) => { | ||
| const client = useApiFetch(Roles); | ||
| return useApiQuery({ | ||
| queryKey: apiQueryKey('v1/roles', undefined, params), | ||
| queryFn: () => client.list(params), | ||
| select: (data) => data.items, | ||
| }); | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -37,6 +37,7 @@ export const buildIdpCreatePayload = ( | |
| ...values.spec.config, | ||
| }, | ||
| }, | ||
| enabled: true, | ||
| }, | ||
| }; | ||
| }; | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.