Skip to content
This repository was archived by the owner on Aug 15, 2026. It is now read-only.

OSAC-2333: Add merge_group trigger to E2E workflow - #356

Closed
omer-vishlitzky wants to merge 1 commit into
osac-project:mainfrom
omer-vishlitzky:OSAC-2333-add-merge-group-trigger
Closed

OSAC-2333: Add merge_group trigger to E2E workflow#356
omer-vishlitzky wants to merge 1 commit into
osac-project:mainfrom
omer-vishlitzky:OSAC-2333-add-merge-group-trigger

Conversation

@omer-vishlitzky

Copy link
Copy Markdown
Contributor

Summary

Adds merge_group to the E2E workflow triggers. This is a prerequisite for enabling GitHub merge queues (github-config PR #134).

When a PR enters the merge queue, GitHub creates a temporary merge ref on top of the latest main and fires a merge_group event. Without this trigger, the E2E workflow wouldn't run on that ref, causing the merge queue to time out.

What changed

One line added to the on: block:

merge_group:

Test plan

  • Verify E2E workflow still triggers normally on PRs (no behavioral change for pull_request events)
  • After github-config PR Bump docker/metadata-action from 5 to 6 #134 is applied, verify merge queue runs E2E against the merge group ref

🤖 Generated with Claude Code

Prerequisite for enabling GitHub merge queues. When a PR enters the
merge queue, GitHub fires a merge_group event — the E2E workflow must
respond to it so CI runs against the temporary merge ref.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@openshift-ci-robot

openshift-ci-robot commented Jul 15, 2026

Copy link
Copy Markdown

@omer-vishlitzky: This pull request references OSAC-2333 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

Adds merge_group to the E2E workflow triggers. This is a prerequisite for enabling GitHub merge queues (github-config PR #134).

When a PR enters the merge queue, GitHub creates a temporary merge ref on top of the latest main and fires a merge_group event. Without this trigger, the E2E workflow wouldn't run on that ref, causing the merge queue to time out.

What changed

One line added to the on: block:

merge_group:

Test plan

  • Verify E2E workflow still triggers normally on PRs (no behavioral change for pull_request events)
  • After github-config PR Bump docker/metadata-action from 5 to 6 #134 is applied, verify merge queue runs E2E against the merge group ref

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Jul 15, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: omer-vishlitzky
Once this PR has been reviewed and has the lgtm label, please assign larsks for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@omer-vishlitzky, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 48 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Repository: osac-project/coderabbit/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: e407a41b-d910-43f9-a15f-c7f201775be1

📥 Commits

Reviewing files that changed from the base of the PR and between d1cf89d and 7c1f8c8.

📒 Files selected for processing (1)
  • .github/workflows/e2e-vmaas-full-install.yml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants