Skip to content
This repository was archived by the owner on Aug 15, 2026. It is now read-only.

OSAC-2822: skip CI for docs-only and metadata-only PRs - #415

Merged
openshift-merge-bot[bot] merged 1 commit into
osac-project:mainfrom
rccrdpccl:ci/skip-tests-for-docs-only-prs
Jul 17, 2026
Merged

OSAC-2822: skip CI for docs-only and metadata-only PRs#415
openshift-merge-bot[bot] merged 1 commit into
osac-project:mainfrom
rccrdpccl:ci/skip-tests-for-docs-only-prs

Conversation

@rccrdpccl

@rccrdpccl rccrdpccl commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Summary

Add paths-ignore filters to all PR-triggered workflows so they don't run when only non-code files change (OWNERS, LICENSE, *.md, docs/**).

Scheduled and workflow_dispatch triggers are unaffected.

Companion PR: osac-project/github-config#131 (migrates required status checks to rulesets so skipped checks don't block merge)

Assisted-by: Claude Code noreply@anthropic.com

Summary by CodeRabbit

  • CI Improvements
    • Documentation-only pull requests no longer trigger several automated validation workflows.
    • End-to-end validation now detects documentation-only changes and skips unnecessary installation tests.
    • End-to-end job results continue to report failures or cancellations clearly.

@openshift-ci-robot

Copy link
Copy Markdown

@rccrdpccl: This pull request explicitly references no jira issue.

Details

In response to this:

Summary

Add paths-ignore filters to all PR-triggered workflows so they don't run when only non-code files change (OWNERS, LICENSE, *.md, docs/**).

Scheduled and workflow_dispatch triggers are unaffected.

Companion PR: osac-project/github-config#131 (migrates required status checks to rulesets so skipped checks don't block merge)

Assisted-by: Claude Code noreply@anthropic.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@rccrdpccl, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 51 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Repository: osac-project/coderabbit/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: 099b1ba7-9b90-47d0-844a-312d642b700b

📥 Commits

Reviewing files that changed from the base of the PR and between ecbc733 and 382042d.

📒 Files selected for processing (5)
  • .github/workflows/ansible-lint.yml
  • .github/workflows/e2e-vmaas-full-install.yml
  • .github/workflows/execution-environment.yml
  • .github/workflows/integration-tests.yml
  • .github/workflows/pre-commit.yaml

Walkthrough

Changes

CI workflow filtering

Layer / File(s) Summary
Documentation path filters
.github/workflows/ansible-lint.yml, .github/workflows/execution-environment.yml, .github/workflows/integration-tests.yml, .github/workflows/pre-commit.yaml
Pull requests changing only OWNERS, LICENSE, Markdown files, or docs/** no longer trigger these workflows.
Full-install E2E gating
.github/workflows/e2e-vmaas-full-install.yml
A path-filter job conditionally runs the full-install job, while an always-running sentinel fails when either dependency fails or is cancelled.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant PullRequest
  participant changes
  participant e2e-vmaas-full-install
  participant e2e
  PullRequest->>changes: classify changed paths
  changes->>e2e-vmaas-full-install: publish should-run
  e2e-vmaas-full-install->>e2e: report job result
  changes->>e2e: report filter result
  e2e->>PullRequest: fail on failure or cancellation
Loading

Possibly related PRs

Suggested labels: lgtm, approved

Suggested reviewers: rgolangh, ybettan, eliorerz

🚥 Pre-merge checks | ✅ 11
✅ Passed checks (11 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: skipping CI for docs-only and metadata-only pull requests.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
No-Hardcoded-Secrets ✅ Passed Diff only adds PR path filters plus a pinned action SHA; no hardcoded secrets, credentials, private keys, or secret-like literals were introduced.
No-Weak-Crypto ✅ Passed Only PR path filters and a job-result sentinel were added; no weak crypto, custom crypto, or secret/token comparisons were introduced.
No-Injection-Vectors ✅ Passed No SQL/eval/pickle/yaml.load/os.system/dangerous HTML patterns were introduced; the only new shell step checks GitHub results against literals.
Container-Privileges ✅ Passed Edited workflows only add PR path filters/flow control; no privileged, hostNetwork/IPC, SYS_ADMIN, or allowPrivilegeEscalation settings were found.
No-Sensitive-Data-In-Logs ✅ Passed No new log statements or debug output were added; the diff only changes PR triggers and a conditional gate, with no secret/PII/customer-data printing.
Ai-Attribution ✅ Passed AI use is attributed with an Assisted-by trailer in the commit/PR body, and no Co-Authored-By AI trailer appears.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@rccrdpccl
rccrdpccl force-pushed the ci/skip-tests-for-docs-only-prs branch from 955f9b0 to e6a2f62 Compare July 16, 2026 09:52
@rccrdpccl
rccrdpccl force-pushed the ci/skip-tests-for-docs-only-prs branch from e6a2f62 to 9f98689 Compare July 16, 2026 12:47
@rccrdpccl rccrdpccl changed the title NO-ISSUE: skip CI for docs-only and metadata-only PRs OSAC-2822: skip CI for docs-only and metadata-only PRs Jul 16, 2026
@openshift-ci-robot

openshift-ci-robot commented Jul 16, 2026

Copy link
Copy Markdown

@rccrdpccl: This pull request references OSAC-2822 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

Add paths-ignore filters to all PR-triggered workflows so they don't run when only non-code files change (OWNERS, LICENSE, *.md, docs/**).

Scheduled and workflow_dispatch triggers are unaffected.

Companion PR: osac-project/github-config#131 (migrates required status checks to rulesets so skipped checks don't block merge)

Assisted-by: Claude Code noreply@anthropic.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rccrdpccl
rccrdpccl force-pushed the ci/skip-tests-for-docs-only-prs branch from 9f98689 to e271f35 Compare July 16, 2026 13:58
@rccrdpccl
rccrdpccl force-pushed the ci/skip-tests-for-docs-only-prs branch from e271f35 to ecbc733 Compare July 16, 2026 14:27

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/e2e-vmaas-full-install.yml:
- Around line 77-80: Replace the inline bash result check with a step-level
GitHub Actions if condition on the step containing the failure exit behavior.
Use the existing needs.*.result values to skip the step unless a dependency is
failure or cancelled, and remove the shell interpolation and conditional script.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository: osac-project/coderabbit/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: 977f7525-b419-47d3-80b7-93c5ee8edf6d

📥 Commits

Reviewing files that changed from the base of the PR and between f5cdc54 and ecbc733.

📒 Files selected for processing (5)
  • .github/workflows/ansible-lint.yml
  • .github/workflows/e2e-vmaas-full-install.yml
  • .github/workflows/execution-environment.yml
  • .github/workflows/integration-tests.yml
  • .github/workflows/pre-commit.yaml

Comment thread .github/workflows/e2e-vmaas-full-install.yml Outdated
Replace paths-ignore (which prevents the workflow from running entirely
and leaves required checks stuck as pending) with dorny/paths-filter to
detect code changes. The e2e job is conditionally skipped via job-level
if:, which GitHub reports as Success. A gate job always runs and reports
the required check status.

Schedule and workflow_dispatch triggers always run the e2e job.

Assisted-by: Claude Code <noreply@anthropic.com>
Signed-off-by: Riccardo Piccoli <rpiccoli@redhat.com>
@rccrdpccl
rccrdpccl force-pushed the ci/skip-tests-for-docs-only-prs branch from ecbc733 to 382042d Compare July 16, 2026 14:35
@omer-vishlitzky

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@openshift-ci

openshift-ci Bot commented Jul 17, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adriengentil, omer-vishlitzky, rccrdpccl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-bot Bot merged commit 7ef486d into osac-project:main Jul 17, 2026
10 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants