OSAC-2822: skip CI for docs-only and metadata-only PRs - #415
Conversation
|
@rccrdpccl: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Warning Review limit reached
Next review available in: 51 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Repository: osac-project/coderabbit/.coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: 📒 Files selected for processing (5)
WalkthroughChangesCI workflow filtering
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant PullRequest
participant changes
participant e2e-vmaas-full-install
participant e2e
PullRequest->>changes: classify changed paths
changes->>e2e-vmaas-full-install: publish should-run
e2e-vmaas-full-install->>e2e: report job result
changes->>e2e: report filter result
e2e->>PullRequest: fail on failure or cancellation
Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 11✅ Passed checks (11 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
955f9b0 to
e6a2f62
Compare
e6a2f62 to
9f98689
Compare
|
@rccrdpccl: This pull request references OSAC-2822 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
9f98689 to
e271f35
Compare
e271f35 to
ecbc733
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/e2e-vmaas-full-install.yml:
- Around line 77-80: Replace the inline bash result check with a step-level
GitHub Actions if condition on the step containing the failure exit behavior.
Use the existing needs.*.result values to skip the step unless a dependency is
failure or cancelled, and remove the shell interpolation and conditional script.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: osac-project/coderabbit/.coderabbit.yaml
Review profile: ASSERTIVE
Plan: Enterprise
Run ID: 977f7525-b419-47d3-80b7-93c5ee8edf6d
📒 Files selected for processing (5)
.github/workflows/ansible-lint.yml.github/workflows/e2e-vmaas-full-install.yml.github/workflows/execution-environment.yml.github/workflows/integration-tests.yml.github/workflows/pre-commit.yaml
Replace paths-ignore (which prevents the workflow from running entirely and leaves required checks stuck as pending) with dorny/paths-filter to detect code changes. The e2e job is conditionally skipped via job-level if:, which GitHub reports as Success. A gate job always runs and reports the required check status. Schedule and workflow_dispatch triggers always run the e2e job. Assisted-by: Claude Code <noreply@anthropic.com> Signed-off-by: Riccardo Piccoli <rpiccoli@redhat.com>
ecbc733 to
382042d
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adriengentil, omer-vishlitzky, rccrdpccl The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary
Add paths-ignore filters to all PR-triggered workflows so they don't run when only non-code files change (OWNERS, LICENSE, *.md, docs/**).
Scheduled and workflow_dispatch triggers are unaffected.
Companion PR: osac-project/github-config#131 (migrates required status checks to rulesets so skipped checks don't block merge)
Assisted-by: Claude Code noreply@anthropic.com
Summary by CodeRabbit