ENH: #273 Adds readonly mode custom var to control deleting and creating nodes via org-roam-ui#276
Open
jeremygooch wants to merge 2 commits intoorg-roam:mainfrom
Open
ENH: #273 Adds readonly mode custom var to control deleting and creating nodes via org-roam-ui#276jeremygooch wants to merge 2 commits intoorg-roam:mainfrom
jeremygooch wants to merge 2 commits intoorg-roam:mainfrom
Conversation
added 2 commits
November 20, 2022 12:15
…rolling editing abilities from org-roam-ui (specifically deleting nodes)
…so puts the create node button behind the boolean.
Author
|
Just found this comment from @tefkah: #249 (comment), so sounds like the public facing version could make the changes in this PR moot. Leaving open just in case it provides value. |
|
It seems that the project is inactive, and thus the public facing version is delayed. It would be nice to atleast have this PR merged until then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor enhancement that adds a new custom variable
org-roam-ui-readonly-modeas a boolean that can be used to disable certain features (currently only create and delete node).Controls showing the options in the UI as well as updating internal functions so these features cannot be called externally outside the UI when set to true/non-nil.