fix: solve attach id not inherited from parents.#218
Open
MephistoMMM wants to merge 2 commits intoorg-roam:mainfrom
Open
fix: solve attach id not inherited from parents.#218MephistoMMM wants to merge 2 commits intoorg-roam:mainfrom
MephistoMMM wants to merge 2 commits intoorg-roam:mainfrom
Conversation
Contributor
|
Looks good for me as a quick fix. (Ideally, this option should be set to
the corresponding emacs option.)
One clarification though: uniorg doesn't check the presence of the
attachment—the inheritance is only used to resolve id/dir
|
Author
You are right, I modified it 👌 |
Contributor
|
Fantastic! I'll add some documentation but otherwise it lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enabling inheritance for implies that attachment links will look through all parent headings until it finds the linked attachment.