Release diff: master → previous_release - #34
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Switch from Paper bootstrap to BukkitHopper.downloadAndLoad() which downloads and loads PacketEvents at runtime without requiring restart. - Replace AacBootstrap with AacHopper using BukkitHopper API - Remove paper-plugin.yml (no longer needed) - Use hopper-bukkit instead of hopper-paper - Simplify command registration (plugin.yml only) - Update documentation to reflect no-restart flow - Reduced logs (uses LogLevel.QUIET) - Bump version to 0.4.1
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| .updatePolicy(UpdatePolicy.MINOR) | ||
| .onFailure(FailurePolicy.WARN_SKIP) | ||
| .build()); | ||
| } |
There was a problem hiding this comment.
GitHub fallback unreachable when Modrinth download fails
The dependency registration intends to use GitHub as a fallback for Modrinth, but this won't work as coded. The Modrinth dependency uses FailurePolicy.FAIL which causes the entire download process to fail immediately if Modrinth is unreachable or fails. The GitHub dependency marked as "Fallback source" with FailurePolicy.WARN_SKIP would never be tried in that scenario. For proper fallback behavior, the Modrinth dependency would need WARN_SKIP so the process continues to try GitHub if Modrinth fails.
| enabled = false; | ||
| logger.info("Auto-download of dependencies is disabled"); | ||
| return; | ||
| } |
There was a problem hiding this comment.
Static enabled flag not reset on plugin reload
The static enabled field is initialized to true but only set to false when the skipDependencyDownload system property is true. If the plugin is reloaded without a server restart (e.g., via a plugin manager), and the property was previously set to true but is now false/unset, enabled remains false from the previous load. This causes dependency downloading to be incorrectly skipped because the register() method never resets enabled back to true when the property is false.
1 participant
Automated PR. The 'previous_release' branch is force-updated on every push to master to point at the commit before the push, so this PR always represents the current release diff.
Note
Plugin runtime changes
AacBootstrap,paper-plugin.yml) with runtime Hopper path: newAacHopperregisters and downloadsPacketEvents(Modrinth primary, GitHub fallback) and loads it duringonLoadinAsyncAnticheatBukkitPlugin— no restart requiredplugin.ymlregistration only; remove CommandMap fallback and related cleanupBuild/config
md.thomas.hopper:hopper-bukkitand keeppacketevents-spigotascompileOnlypluginVersionto0.4.1Docs
.claude/CLAUDE.md,README.md, andweb/content/installation/index.mdxto reflect automatic download + load ofPacketEventswithout restart and adjust setup stepsWritten by Cursor Bugbot for commit 3ee41a5. This will update automatically on new commits. Configure here.