nfs-kernel-server: update to 2.9.1 and fix up v3 init and package#29122
Open
graysky2 wants to merge 2 commits intoopenwrt:masterfrom
Open
nfs-kernel-server: update to 2.9.1 and fix up v3 init and package#29122graysky2 wants to merge 2 commits intoopenwrt:masterfrom
graysky2 wants to merge 2 commits intoopenwrt:masterfrom
Conversation
Update to 2.9.1 which includes a new dependency on libnl, see changelog. Changelog: https://www.kernel.org/pub/linux/utils/nfs-utils/2.9.1/2.9.1-Changelog This upstream release has some peculiar commits, including disabling NFS v4.0 by default and cache up calls migrated from /proc to netlink. In my testing, two parameters are needed to the nfsv4.init file in order to maintain functionality. Without these changes, there's a 90-second period where the shares are simply unavailable. Note that this cannot be merged until the changes to libnl have been merged first. See: openwrt/openwrt#22889 Signed-off-by: John Audia <therealgraysky@proton.me>
ca5b2db to
ea4bde8
Compare
v3 init: - Mirror upstream systemd service; use nfsdctl to manage the server - Add /etc/nfs.conf to restrict to NFSv3 only: % cat /proc/fs/nfsd/versions +3 -4 -4.0 -4.1 -4.2 v4 init: - Remove dead procd_append_param -F from nfsdcld instance - Add respawn to nfsv4.exportd and rpc.idmapd; exclude nfsdcld as it daemonizes and would spawn duplicates under procd respawn - Remove unused NFSDCLD_PID variable; nfsdcld writes no pidfile - Add status_service() using pgrep; procd permanently misreports nfsdcld as stopped due to its daemonization behavior exports: - Supply unified /etc/exports covering both v3 and v4 syntax so the file survives switching between package variants Signed-off-by: John Audia <therealgraysky@proton.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📦 Package Details
Maintainer: me
(You can find this by checking the history of the package
Makefile.)Description:
Update to 2.9.1 which includes a new dependency on libnl, see changelog.
Changelog: https://www.kernel.org/pub/linux/utils/nfs-utils/2.9.1/2.9.1-Changelog
This upstream release has some peculiar commits, including disabling NFS v4.0 by default and cache up calls migrated from /proc to netlink. In my testing, two parameters are needed to the nfsv4.init file in order to maintain functionality. Without these changes, there's a 90-second period where the shares are simply unavailable.
Beyond the update, this PR also modifies the v3 init script to mirrors upstream systemd's service, which includes
shipping
nfsdctland using it to manage the server. Also include/etc/nfs.confto limit to pure version 3 for this package since the kmod supports all versions this confuses the server executable when started.Without the limits in /etc/nfs.conf:
With them we get a pure v3:
Finally supply a unified
/etc/exportssince this file will remain if users change from v3 to v4 or vice-verse, both syntax examples should be included.Note that this cannot be merged until the changes to libnl have been merged first. See: openwrt/openwrt#22889
🧪 Run Testing Details
✅ Formalities
If your PR contains a patch:
git am(e.g., subject line, commit description, etc.)
We must try to upstream patches to reduce maintenance burden.