openvpn: handler: refine netifd routing and config#29121
Merged
feckert merged 1 commit intoopenwrt:masterfrom Apr 17, 2026
Merged
openvpn: handler: refine netifd routing and config#29121feckert merged 1 commit intoopenwrt:masterfrom
feckert merged 1 commit intoopenwrt:masterfrom
Conversation
Contributor
Author
Contributor
|
I merged the other PR first, so this needs to be rebased. |
systemcrash
reviewed
Apr 13, 2026
feckert
reviewed
Apr 15, 2026
Introduce a new `ipv6` proto option for OpenVPN netifd integration and export it to the hotplug environment. IPv6 remains enabled by default, but can now be explicitly disabled per instance. Update the hotplug helper to apply IPv6 addresses and routes only when IPv6 is enabled, allowing cleaner IPv4-only tunnel deployments. Also improve route handling by: - ignoring invalid default gateway values (0.0.0.0 / ::) - replacing fixed `seq` loops with shell-safe while loops - keeping trusted peer host routes conditional on valid gateways Signed-off-by: Chen Minqiang <ptpt52@gmail.com>
Contributor
Author
|
update: |
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces several improvements to the openvpn proto handler and hotplug script:
ipv6boolean option (default: 1) to allow enabling/disabling IPv6 hotplug processing.trusted_ipandtrusted_ip6if the gateway is unspecified ("0.0.0.0" or "::").@feckert