xtables-addons: fix build with Linux 6.18#29099
Closed
pesa1234 wants to merge 1 commit intoopenwrt:masterfrom
Closed
xtables-addons: fix build with Linux 6.18#29099pesa1234 wants to merge 1 commit intoopenwrt:masterfrom
pesa1234 wants to merge 1 commit intoopenwrt:masterfrom
Conversation
ACCOUNT, pknock and LUA still use EXTRA_CFLAGS in their Kbuild files to add local include paths. With Linux 6.18, external modules should use ccflags-y for these include directories instead. Otherwise the additional include paths are not propagated reliably and the build can fail with missing compat_xtables.h. Linux 6.18 also changed the timer API used by pknock, removing from_timer() and del_timer(). Add a small compatibility wrapper so pknock uses timer_container_of() and timer_delete() on 6.18+ while remaining compatible with older kernels. Bump PKG_RELEASE accordingly. Signed-off-by: Andrea Pesaresi <andreapesaresi82@gmail.com>
Member
Contributor
Author
Sorry, I didn't see it. Feel free to close or let me know if I need to do it. Thanks a lot for point me on it |
Member
|
I close this. PR https://github.com/openwrt/packages/pull/28167/changes was merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📦 Package Details
Maintainer: Jo-Philipp Wich jo@mein.io
Description:
ACCOUNT, pknock and LUA still use EXTRA_CFLAGS in their Kbuild files to add local include paths.
With Linux 6.18, external modules should use ccflags-y for these include directories instead. Otherwise the additional include paths are not propagated reliably and the build can fail with missing compat_xtables.h.
Linux 6.18 also changed the timer API used by pknock, removing from_timer() and del_timer(). Add a small compatibility wrapper so pknock uses timer_container_of() and timer_delete() on 6.18+ while remaining compatible with older kernels.
🧪 Run Testing Details
✅ Formalities
If your PR contains a patch:
git am(e.g., subject line, commit description, etc.)
We must try to upstream patches to reduce maintenance burden.