[examples] Remove node expand/fold example and related code #492#517
[examples] Remove node expand/fold example and related code #492#517Sohaibkundi2 wants to merge 2 commits into
Conversation
The node expand/fold example was broken locally with 'Uncaught ReferenceError: module is not defined' and is no longer used in OpenWISP. Removed: - example_templates/netjsongraph-nodeExpand.html - public/assets/data/netjsongraph-foldNodes.json - related import and entry in test/browser.test.utils.js - card link from index.html
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThis pull request removes the "Nodes expand or fold" example and its assets: the example template Sequence Diagram(s)(Skipped — change is removal of example files and does not introduce or alter multi-component control flow requiring a sequence diagram.) Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
nemesifier
left a comment
There was a problem hiding this comment.
This example needed some logic in the library which would remain lingering with no benefit. We must remove the logic on which the examples relied too.
|
Hi @Sohaibkundi2 👋, This pull request has been marked as stale due to 22 days of inactivity after changes were requested. As a result, any linked issues are being unassigned from you so other contributors can pick them up. However, you can still continue working on this PR! If you push new commits or respond to the review feedback:
If you need more time or have questions about the requested changes, please let us know. We're happy to help! 🤝 |
The node expand/fold example was broken locally with 'Uncaught ReferenceError: module is not defined' and is no longer used in OpenWISP.
Removed:
Description of Changes
Removes the broken node expand/fold example as discussed in #492.
The example was failing locally with
Uncaught ReferenceError: module is not defined.This is a focused PR addressing only the nodeExpand removal item from the issue.
Checklist
Reference to Existing Issue
Related to #492
Screenshot
Not applicable - this PR removes a broken example, no visual changes.