Skip to content

Fix: change LoadSecret logic for empty metadata #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kohelbekker wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: change LoadSecret logic for empty metadata #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,15 @@ To **delete** existing secrets for a given app name and scope, run:
vault delete secret/data/$KAIGARA_DEPLOYMENT_ID/$KAIGARA_APP_NAME/*scope*
```

To delete all versions and metadata for the provided key for a given app name and scope, run:
```sh
vault kv metadata delete secret/$KAIGARA_DEPLOYMENT_ID/$KAIGARA_APP_NAME/*scope*
```
This command don't remove the underlying version data from storage, it will mark the version as deleted which allows the version to be undeleted - `vault kv undelete`, while next command will make version data permanently deleted:
```sh
vault kv metadata destroy secret/$KAIGARA_DEPLOYMENT_ID/$KAIGARA_APP_NAME/*scope*
```

### Bulk writing secrets to the SecretStore

To write secrets from the command line, save in a YAML file with a format similar to `secrets.yaml` and use `kaisave -f *filepath*`
Expand Down
2 changes: 1 addition & 1 deletion pkg/vault/vault.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ func (vs *Service) LoadSecrets(appName, scope string) error {
vs.metadata[appName] = make(map[string]interface{})
}

if secret == nil || secret.Data == nil || secret.Data["data"] == nil {
if secret == nil || secret.Data == nil || secret.Data["data"] == nil || secret.Data["metadata"] == nil {
vs.data[appName][scope] = make(map[string]interface{})
vs.metadata[appName][scope] = make(map[string]interface{})
} else {
Expand Down