Switch GTFS flex safe_duration_offset back to seconds - #6298
Merged
leonardehrenfried merged 1 commit intoDec 4, 2024
Conversation
leonardehrenfried
added
!Improvement
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #6298 +/- ##
=============================================
- Coverage 69.79% 69.79% -0.01%
+ Complexity 17790 17787 -3
=============================================
Files 2017 2017
Lines 76042 76042
Branches 7781 7781
=============================================
- Hits 53077 53076 -1
Misses 20263 20263
- Partials 2702 2703 +1 ☔ View full report in Codecov by Sentry. |
habrahamsson-skanetrafiken
requested review from
binh-dam-ibigroup and
tkalvas
December 3, 2024 09:22
leonardehrenfried
enabled auto-merge
December 3, 2024 09:54
tkalvas
approved these changes
Dec 4, 2024
binh-dam-ibigroup
approved these changes
Dec 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
There has been a bit of unfortunate back-and-forth when writing the spec draft for the GTFS flex duration extension. We agreed that we want to switch the field
safe_duration_offsetto mean seconds as other duration in the spec also us this unit.Issue
MobilityData/gtfs-flex#79
Unit tests
Updated.
Documentation
No.