Skip to content

migrate contract e2e #2716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
open-junius wants to merge 12 commits into
base: devnet-ready
Choose a base branch
from
Draft

migrate contract e2e #2716

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
204908c
migrate contract e2e
open-junius Jun 4, 2026
8959e8f
chore: auditor auto-fix
Jun 4, 2026
faaf273
update ci configure
open-junius Jun 4, 2026
5ed2219
fmt file
open-junius Jun 4, 2026
62e1210
fix format
open-junius Jun 5, 2026
2987050
Merge branch 'devnet-ready' into migrate-contract-e2e
open-junius Jun 5, 2026
5ffa344
commit Cargo.lock
open-junius Jun 5, 2026
b1718a8
remove config import
open-junius Jun 5, 2026
86ffee7
migrate whole evm substrate transfer test
open-junius Jun 5, 2026
cdf5a5e
merge devnet ready
open-junius Jun 5, 2026
d4903cd
chore: auditor auto-fix
Jun 5, 2026
519d0e4
format code
open-junius Jun 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/typescript-e2e.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,8 @@ jobs:
binary: fast
- test: zombienet_subnets
binary: fast
- test: zombienet_evm
binary: fast

name: "typescript-e2e-${{ matrix.test }}"

Expand Down
407 changes: 0 additions & 407 deletions contract-tests/test/eth.substrate-transfer.test.ts
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion pallets/subtensor/src/staking/order_swap.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ impl<T: Config> OrderSwapInterface<T::AccountId> for Pallet<T> {
}
let alpha_out =
Self::stake_into_subnet(hotkey, coldkey, netuid, tao_amount, amm_limit, false)?;

Ok(alpha_out)
}

Expand Down
32 changes: 32 additions & 0 deletions ts-tests/moonwall.config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,38 @@
"endpoints": ["ws://127.0.0.1:9947"]
}
]
}, {
"name": "zombienet_evm",
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot Jun 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[MEDIUM] Wire the new EVM suite into CI

This registers a new zombienet_evm Moonwall suite, but .github/workflows/typescript-e2e.yml still only runs dev, zombienet_shield, zombienet_staking, zombienet_coldkey_swap, and zombienet_subnets. As written, the migrated EVM test can go stale because PR CI never invokes pnpm moonwall test zombienet_evm.

Add zombienet_evm to the run-e2e-tests matrix, likely against the release binary unless there is a specific fast-runtime reason.

"timeout": 600000,
"testFileDir": ["suites/zombienet_evm"],
"runScripts": [
"generate-types.sh",
"build-spec.sh"
],
"foundation": {
"type": "zombie",
"zombieSpec": {
"configPath": "./configs/zombie_node.json",
"skipBlockCheck": []
}
},
"vitestArgs": {
"bail": 1
},
"connections": [
{
"name": "Node",
"type": "papi",
"endpoints": ["ws://127.0.0.1:9947"],
"descriptor": "subtensor"
},
{
"name": "EVM",
"type": "ethers",
"endpoints": ["http://127.0.0.1:9947"],
"descriptor": "evm"
}
]
}, {
"name": "zombienet_subnets",
"timeout": 600000,
Expand Down
13 changes: 13 additions & 0 deletions ts-tests/pnpm-workspace.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,16 @@ onlyBuiltDependencies:
- protobufjs
- sqlite3
- ssh2

# Allow exotic subdependencies (needed for toml dependency)
allowExoticSubdeps: true

allowBuilds:
'@biomejs/biome': set this to true or false
'@parcel/watcher': set this to true or false
cpu-features: set this to true or false
esbuild: set this to true or false
msgpackr-extract: set this to true or false
protobufjs: set this to true or false
sqlite3: set this to true or false
ssh2: set this to true or false
Comment on lines +20 to +28
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot Jun 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[LOW] Resolve allowBuilds placeholders

The new allowBuilds map still contains generated placeholder strings instead of explicit boolean decisions. pnpm 10.26+ defines this field as a map that explicitly allows (true) or disallows (false) dependency build scripts, so leaving set this to true or false here keeps the new policy unresolved and can cause install-time warnings or stricter future failures. (newreleases.io)

Suggested change
allowBuilds:
'@biomejs/biome': set this to true or false
'@parcel/watcher': set this to true or false
cpu-features: set this to true or false
esbuild: set this to true or false
msgpackr-extract: set this to true or false
protobufjs: set this to true or false
sqlite3: set this to true or false
ssh2: set this to true or false
allowBuilds:
'@biomejs/biome': true
'@parcel/watcher': true
cpu-features: true
esbuild: true
msgpackr-extract: true
protobufjs: true
sqlite3: true
ssh2: true

Comment on lines +20 to +28
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot Jun 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[LOW] Resolve allowBuilds placeholders

This allowBuilds block still contains generated placeholder values instead of concrete booleans. Since the same packages are already listed under onlyBuiltDependencies, leaving these placeholder strings makes the workspace policy ambiguous and can confuse future pnpm maintenance. Either remove the unfinished block or replace each entry with intentional true/false values.

Comment on lines +20 to +28
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot Jun 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[LOW] Resolve allowBuilds placeholders

The allowBuilds entries are still literal placeholder strings (set this to true or false). Resolve this before merge by either replacing them with explicit boolean policy values or removing the block if onlyBuiltDependencies above is the intended source of truth. Leaving generated placeholders makes the install policy ambiguous and can confuse future pnpm approve-builds or dependency review work.

Comment on lines +21 to +28
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot Jun 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[LOW] Resolve allowBuilds placeholders

These entries are still the literal placeholder strings from pnpm approve-builds. Please replace each value with an explicit boolean policy, or remove the allowBuilds block if onlyBuiltDependencies is the intended policy source. Leaving placeholders makes the workspace build policy ambiguous and carries forward the prior review finding.

Comment on lines +21 to +28
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot Jun 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[LOW] Resolve allowBuilds placeholders

These literal placeholder strings are still committed under allowBuilds. pnpm expects concrete boolean approvals here; leaving set this to true or false makes the build-script policy ambiguous and can break strict install/config validation. Since these packages are already listed in onlyBuiltDependencies, set the corresponding approvals explicitly.

Suggested change
'@biomejs/biome': set this to true or false
'@parcel/watcher': set this to true or false
cpu-features: set this to true or false
esbuild: set this to true or false
msgpackr-extract: set this to true or false
protobufjs: set this to true or false
sqlite3: set this to true or false
ssh2: set this to true or false
'@biomejs/biome': true
'@parcel/watcher': true
cpu-features: true
esbuild: true
msgpackr-extract: true
protobufjs: true
sqlite3: true
ssh2: true

Loading
Loading