Use ParityDb weights by default

[l0r1s]

Summary

• Switch the runtime DbWeight from RocksDbWeight to ParityDbWeight.
• Update the benchmark weight template to emit ParityDbWeight for fallback WeightInfo for () implementations.
• Regenerate the existing pallet weight files so their fallback DB read/write costs match the ParityDB default.

Rationale

The node now defaults to ParityDB, but the runtime still used RocksDB database weights when resolving pallet weights through T::DbWeight. This made runtime DB read/write accounting inconsistent with the configured backend.

Most production pallet weights already delegate DB read/write costs through T::DbWeight; updating the runtime fixes that path. The generated fallback implementations in pallets/*/src/weights.rs still hardcoded RocksDbWeight, so those were updated as well, along with the shared benchmark template to keep future generated weights aligned.

[github-actions]

AI review — see the sticky summary comment for the verdict and the inline comments below for specific findings.

[github-actions]

[HIGH] Runtime behavior changes without a spec_version bump

This changes frame_system::Config::DbWeight, so runtime behavior and weight accounting differ from the base runtime, but the diff does not update Version.spec_version (currently still 414 in runtime/src/lib.rs). Substrate uses runtime versions to decide whether native runtime execution is compatible with on-chain Wasm; shipping changed native runtime logic under the same spec version risks nodes treating different runtime code as equivalent. Bump spec_version in this PR alongside the DbWeight change.

[github-actions]

🛡️ AI Review — Skeptic (security review)

VERDICT: VULNERABLE

LOW scrutiny: established write-permission contributor on parity-db-weights -> devnet-ready; no Gittensor allowlist hit found in the trusted local data.

No .github/ai-review/*, copilot-instructions, dependency, lockfile, or build-script changes were present. The diff is otherwise a narrow RocksDbWeight-to-ParityDbWeight runtime/weights update.

Findings

Sev	File	Finding
HIGH	runtime/src/lib.rs:365	Runtime behavior changes without a spec_version bump	inline

Conclusion

The PR changes runtime behavior but does not bump spec_version, which can make native/runtime version matching unsafe across nodes. Fixing the runtime version bump should clear the security concern.

---

# 🔍 AI Review — Auditor (domain review) has not yet run on this PR.

[github-actions]

🔄 AI review updated — Skeptic: VULNERABLE