📝 CodeRabbit Chat: Implement requested code changes#3596
Open
coderabbitai[bot] wants to merge 6 commits into
Open
📝 CodeRabbit Chat: Implement requested code changes#3596coderabbitai[bot] wants to merge 6 commits into
coderabbitai[bot] wants to merge 6 commits into
Conversation
Add an optional owning namespace to resource mappings, mirroring the namespacing already present on registered resources: - ResourceMapping gains a hydrated policy.Namespace field. - Create/UpdateResourceMappingRequest gain optional namespace_id and namespace_fqn. - ListResourceMappingsRequest gains optional namespace_id/namespace_fqn filters; ListResourceMappingGroupsRequest gains namespace_fqn parity. Regenerated protocol/go, OpenAPI/gRPC docs, and SDK wrappers. Adds proto validation unit tests for the new fields. Signed-off-by: Krish Suchak <suchak.krish@gmail.com>
Address review feedback on the resource mapping protos: - Switch namespace_id/namespace_fqn validation to the house buf.validate.message.oneof + string.uuid/string.uri pattern (matching subject_mapping/registered_resources), making the two mutually exclusive. - Add namespace_fqn to CreateResourceMappingGroupRequest (oneof required) and UpdateResourceMappingGroupRequest (oneof optional). - Regenerate protocol/go + docs; update/extend proto validation unit tests. Signed-off-by: Krish Suchak <suchak.krish@gmail.com>
Cover the invalid-UUID path for namespace_id on CreateResourceMappingGroup validation, and invalid namespace_id/namespace_fqn on UpdateResourceMappingGroup, per review feedback. Signed-off-by: Krish Suchak <suchak.krish@gmail.com>
Author
|
Important Review skippedThis PR was authored by the user configured for CodeRabbit reviews. CodeRabbit does not review PRs authored by this user. It's recommended to use a dedicated user account to post CodeRabbit review feedback. ⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
github-actions
Bot
added
the
comp:policy
Contributor
|
Contributor
Benchmark results, click to expandBenchmark authorization.GetDecisions Results:
Benchmark authorization.v2.GetMultiResourceDecision Results:
Benchmark Statistics
Bulk Benchmark Results
TDF3 Benchmark Results:
|
Contributor
alkalescent
force-pushed
the
DSPX-2998-optional-namespace-resource-mappings
branch
from
a8fa30f to
b8879a8
Compare
Base automatically changed from
DSPX-2998-optional-namespace-resource-mappings
to
main
June 10, 2026 20:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code changes was requested by @alkalescent.
The following files were modified:
service/policy/resourcemapping/resource_mapping_test.go