Prevent logout while filling in a questionnaire (+ offline redirect fix)#3843
Open
allan-on wants to merge 3 commits into
Open
Prevent logout while filling in a questionnaire (+ offline redirect fix)#3843allan-on wants to merge 3 commits into
allan-on wants to merge 3 commits into
Conversation
allan-on
force-pushed
the
fix/prevent-logout-mid-filling-in-questionnaire
branch
from
June 11, 2026 06:40
1df5e84 to
2a4449f
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3843 +/- ##
=========================================
- Coverage 25.0% 24.6% -0.4%
- Complexity 844 853 +9
=========================================
Files 297 305 +8
Lines 16102 16538 +436
Branches 2689 2749 +60
=========================================
+ Hits 4038 4082 +44
- Misses 11580 11968 +388
- Partials 484 488 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Covers the logout-prevention implementation cherry-picked from 75eb346: - TokenAuthenticator: verify that suppressLoginRedirect skips session PIN deletion and LoginActivity launch when set, and performs them when unset. - QuestionnaireActivity: verify suppressLoginRedirect is enabled while the questionnaire is open and reset on destroy.
allan-on
force-pushed
the
fix/prevent-logout-mid-filling-in-questionnaire
branch
from
June 11, 2026 07:19
2a4449f to
ef37900
Compare
LZRS
approved these changes
Jun 11, 2026
allan-on
enabled auto-merge
June 11, 2026 14:58
ellykits
requested changes
Jun 12, 2026
ellykits
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the PR @allan-on, while this temporarily fixes the issue, the underlying reason why this happen is not actually addressed in this PR. What we are doing is suppressing the redirect to the login page, via a class property flag. What would happen when the class is garbage collected? Can we think about resolving this in a different way?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings the "prevent redirecting to the login screen in the middle of filling in a Questionnaire" implementation to
main, together with its follow-up bug fix.Both changes currently live only on
custom-engage; this PR cherry-picks them onto a branch offmain:Prevent logout when filling questionnaire(cherry-picked from75eb3468d, by @FikriMilano)If refresh token expired redirect to login if online(cherry-picked from81240e7d5) — fixes Offline session-expired re-authentication loop after questionnaire submit #3842