Commit ae23adf
[hack] Address review feedback in create-release-tag.py
- Resolve git executable via shutil.which() and catch OSError in git()
so callers always receive RuntimeError instead of an unhandled
FileNotFoundError when git is missing or fails to launch
- Use git rev-parse --verify refs/tags/<tag> in tag_exists() so only
actual tags (not branches with the same name) return True
- Replace regex date validation with date.fromisoformat() to reject
invalid calendar dates such as 2026-02-31 at argument-parse time
- Wrap fetch_bundle_info() and fetch_operator_push_date() calls in
try/except so network, HTTP, or JSON errors surface as clean ERROR
messages matching the existing git-failure error style
Signed-off-by: Russell Teague <rteague@redhat.com>
Co-Authored-By: Claude <noreply@anthropic.com>1 parent 192dbea commit ae23adf
1 file changed
Lines changed: 39 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
99 | 99 | | |
100 | 100 | | |
101 | 101 | | |
| 102 | + | |
102 | 103 | | |
103 | 104 | | |
| 105 | + | |
104 | 106 | | |
105 | 107 | | |
106 | 108 | | |
| |||
211 | 213 | | |
212 | 214 | | |
213 | 215 | | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
214 | 219 | | |
215 | 220 | | |
216 | | - | |
217 | | - | |
218 | | - | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
219 | 233 | | |
220 | 234 | | |
221 | 235 | | |
| |||
224 | 238 | | |
225 | 239 | | |
226 | 240 | | |
227 | | - | |
| 241 | + | |
228 | 242 | | |
229 | 243 | | |
230 | 244 | | |
| |||
294 | 308 | | |
295 | 309 | | |
296 | 310 | | |
297 | | - | |
298 | | - | |
| 311 | + | |
| 312 | + | |
| 313 | + | |
| 314 | + | |
| 315 | + | |
299 | 316 | | |
300 | 317 | | |
301 | 318 | | |
| |||
321 | 338 | | |
322 | 339 | | |
323 | 340 | | |
324 | | - | |
| 341 | + | |
| 342 | + | |
| 343 | + | |
| 344 | + | |
| 345 | + | |
| 346 | + | |
| 347 | + | |
| 348 | + | |
325 | 349 | | |
326 | 350 | | |
327 | 351 | | |
| |||
342 | 366 | | |
343 | 367 | | |
344 | 368 | | |
345 | | - | |
| 369 | + | |
| 370 | + | |
| 371 | + | |
| 372 | + | |
| 373 | + | |
| 374 | + | |
| 375 | + | |
| 376 | + | |
346 | 377 | | |
347 | 378 | | |
348 | 379 | | |
| |||
0 commit comments