[hack] Fix linting issues in create-release-tag.py

- Wrap all lines to the 79-character flake8 limit
- Add check=False to subprocess.run (W1510)
- Chain exception with raise...from exc in resolve_commit (W0707)
- Add missing docstrings to tag_exists and main (C0116)
- Suppress invalid-name for the hyphenated script filename (C0103)
- Suppress main() complexity warnings with inline disable (R0912/R0914/R0915)

pylint score: 10.00/10

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: mtnbikenc

hack/create-release-tag.py

@@ -11,7 +11,8 @@
     python3 hack/create-release-tag.py <version>
     python3 hack/create-release-tag.py <version> --commit <SHA>
     python3 hack/create-release-tag.py <version> --date YYYY-MM-DD
-    python3 hack/create-release-tag.py <version> --commit <SHA> --date YYYY-MM-DD
+    python3 hack/create-release-tag.py <version> --commit <SHA> \
+        --date YYYY-MM-DD
 
     --commit is required when the version has no entry in the bundle catalog
     (e.g. backport releases that were never shipped as a container image).
@@ -33,15 +34,15 @@
     hex SHA that Konflux publishes as an image tag alongside the version tag.
 
     Operator image:  openshift4-wincw/windows-machine-config-rhel9-operator
-    Provides: push_date — the UTC timestamp when the image was published to the
-    catalog.  This is used as the tag date so the annotated tag timestamp
+    Provides: push_date — the UTC timestamp when the image was published to
+    the catalog.  This is used as the tag date so the annotated tag timestamp
     reflects the actual release date rather than the date the tag was created.
 
   Local git repository
-    Provides: existing tag detection (prevents accidental overwrites), full SHA
-    expansion from short SHAs via git rev-parse, commit existence verification
-    to catch catalog/repo mismatches before the tag is written, and upstream
-    remote detection for the post-creation push instruction.
+    Provides: existing tag detection (prevents accidental overwrites), full
+    SHA expansion from short SHAs via git rev-parse, commit existence
+    verification to catch catalog/repo mismatches before the tag is written,
+    and upstream remote detection for the post-creation push instruction.
 
 ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 LOGIC
@@ -53,7 +54,8 @@
              image tag (fallback for images that predate the OCI label).
    Logic:
      • Scans the bundle catalog for the image whose tags include vX.Y.Z.
-     • Prefers the full SHA from the OCI label; falls back to the short SHA tag.
+     • Prefers the full SHA from the OCI label; falls back to the short SHA
+       tag.
      • Any SHA (full or short) is expanded to a full 40-character commit via
        git rev-parse and verified to exist locally.  This catches catalog/repo
        mismatches (e.g. if the local clone is stale) before writing anything.
@@ -63,13 +65,16 @@
 
 2. TAG DATE RESOLUTION
    Source:   Operator image catalog
-   Data:     push_date field from the repository entry for the matching version.
+   Data:     push_date field from the repository entry for the matching
+             version.
    Logic:
-     • The push_date is the UTC timestamp when the operator image was published.
-     • Only the date portion (YYYY-MM-DD) is used; the time is fixed to noon UTC
-       (12:00:00+0000) to produce an unambiguous, timezone-neutral timestamp.
-     • The fixed noon time is set via GIT_COMMITTER_DATE when git tag is invoked,
-       so it appears as the tag's creation date in git log and GitHub.
+     • The push_date is the UTC timestamp when the operator image was
+       published.
+     • Only the date portion (YYYY-MM-DD) is used; the time is fixed to noon
+       UTC (12:00:00+0000) to produce an unambiguous, timezone-neutral
+       timestamp.
+     • The fixed noon time is set via GIT_COMMITTER_DATE when git tag is
+       invoked, so it appears as the tag's creation date in git log and GitHub.
      • --date skips the catalog lookup and uses the provided date instead.
 
 3. TAG CREATION
@@ -85,12 +90,14 @@
 4. PUSH INSTRUCTION
    Logic:
      • After creation, scans git remote -v for a remote whose URL contains
-       "openshift/windows-machine-config-operator" and uses its configured name
-       (commonly "upstream") in the suggested push command.
+       "openshift/windows-machine-config-operator" and uses its configured
+       name (commonly "upstream") in the suggested push command.
      • Falls back to the canonical SSH URL if no matching remote is found, so
        the command is always complete and immediately usable.
 """
 
+# pylint: disable=invalid-name  # hyphenated script name is intentional
+
 import argparse
 import os
 import re
@@ -119,11 +126,19 @@
 # ---------------------------------------------------------------------------
 
 def _fetch_pages(api_url: str) -> list:
-    """Fetch all image records from a catalog API endpoint, handling pagination."""
+    """Fetch all image records from a catalog API endpoint,
+    handling pagination."""
     images, page = [], 0
     while True:
-        resp = requests.get(api_url, params={"page_size": 100, "page": page,
-                                             "sort_by": "creation_date[desc]"}, timeout=30)
+        resp = requests.get(
+            api_url,
+            params={
+                "page_size": 100,
+                "page": page,
+                "sort_by": "creation_date[desc]",
+            },
+            timeout=30,
+        )
         resp.raise_for_status()
         batch = resp.json().get("data", [])
         if not batch:
@@ -152,19 +167,25 @@ def _labels(img: dict) -> dict:
 
 def fetch_bundle_info(version: str) -> tuple[str, str]:
     """
-    Return (commit, source_description) for the given version from the bundle catalog.
-    Prefers the org.opencontainers.image.revision label (full SHA); falls back to
-    the short hex SHA image tag.  Returns ('', '') if the version is not found.
+    Return (commit, source_description) for the given version from the
+    bundle catalog.  Prefers the org.opencontainers.image.revision label
+    (full SHA); falls back to the short hex SHA image tag.
+    Returns ('', '') if the version is not found.
     """
     for img in _fetch_pages(BUNDLE_CATALOG_API):
         repos = img.get("repositories", [])
         if _version_from_tags(repos) != version:
             continue
-        all_tags = [t.get("name", "") for repo in repos for t in repo.get("tags", [])]
+        all_tags = [
+            t.get("name", "") for repo in repos for t in repo.get("tags", [])
+        ]
         commit = _labels(img).get("org.opencontainers.image.revision", "")
         if commit:
             return commit, "bundle image OCI label"
-        sha_tags = [t for t in all_tags if _HEX_RE.match(t) and not _VERSION_TAG_RE.match(t)]
+        sha_tags = [
+            t for t in all_tags
+            if _HEX_RE.match(t) and not _VERSION_TAG_RE.match(t)
+        ]
         if sha_tags:
             return sha_tags[0], "bundle image tag (short SHA)"
         return "", ""
@@ -173,8 +194,8 @@ def fetch_bundle_info(version: str) -> tuple[str, str]:
 
 def fetch_operator_push_date(version: str) -> str:
     """
-    Return the push_date (YYYY-MM-DD) for the given version from the operator catalog,
-    or '' if not found.
+    Return the push_date (YYYY-MM-DD) for the given version from the
+    operator catalog, or '' if not found.
     """
     for img in _fetch_pages(OPERATOR_CATALOG_API):
         for repo in img.get("repositories", []):
@@ -192,13 +213,16 @@ def fetch_operator_push_date(version: str) -> str:
 
 def git(*args, env=None) -> str:
     """Run a git command and return stdout, raising on failure."""
-    result = subprocess.run(["git", *args], capture_output=True, text=True, env=env)
+    result = subprocess.run(
+        ["git", *args], capture_output=True, text=True, env=env, check=False
+    )
     if result.returncode != 0:
         raise RuntimeError(result.stderr.strip())
     return result.stdout.strip()
 
 
 def tag_exists(tag: str) -> bool:
+    """Return True if the git tag already exists in this repository."""
     try:
         git("rev-parse", tag)
         return True
@@ -210,11 +234,11 @@ def resolve_commit(ref: str) -> str:
     """Return the full commit SHA for ref, or raise RuntimeError."""
     try:
         return git("rev-parse", f"{ref}^{{commit}}")
-    except RuntimeError:
+    except RuntimeError as exc:
         raise RuntimeError(
             f"Commit '{ref}' not found in this repository.\n"
             "Ensure your local repo is up to date: git fetch origin"
-        )
+        ) from exc
 
 
 # ---------------------------------------------------------------------------
@@ -223,8 +247,8 @@ def resolve_commit(ref: str) -> str:
 
 def _find_upstream_remote() -> str:
     """
-    Return the name of the remote pointing to openshift/windows-machine-config-operator,
-    or '' if none is configured.
+    Return the name of the remote pointing to
+    openshift/windows-machine-config-operator, or '' if none is configured.
     """
     try:
         lines = git("remote", "-v").splitlines()
@@ -233,12 +257,15 @@ def _find_upstream_remote() -> str:
     for line in lines:
         # Each line: "<name>\t<url> (fetch|push)"
         parts = line.split()
-        if len(parts) >= 2 and "openshift/windows-machine-config-operator" in parts[1]:
+        if (len(parts) >= 2
+                and "openshift/windows-machine-config-operator" in parts[1]):
             return parts[0]
     return ""
 
 
+# pylint: disable=too-many-locals,too-many-branches,too-many-statements
 def main():
+    """Parse args, resolve tag details, confirm with user, create the tag."""
     parser = argparse.ArgumentParser(
         description="Create an annotated WMCO release tag.",
         formatter_class=argparse.RawDescriptionHelpFormatter,
@@ -255,8 +282,10 @@ def main():
     )
     parser.add_argument("version", metavar="X.Y.Z",
                         help="Release version without 'v' prefix")
-    parser.add_argument("--commit", metavar="SHA",
-                        help="Override commit SHA (required if version is not in catalog)")
+    parser.add_argument(
+        "--commit", metavar="SHA",
+        help="Override commit SHA (required if version is not in catalog)",
+    )
     parser.add_argument("--date", metavar="YYYY-MM-DD",
                         help="Override published date")
     args = parser.parse_args()
@@ -273,24 +302,40 @@ def main():
     message = f"Windows Machine Config Operator {tag}"
 
     if tag_exists(tag):
-        print(f"ERROR: Tag '{tag}' already exists. Delete it first if you intend to recreate it.",
-              file=sys.stderr)
+        print(
+            f"ERROR: Tag '{tag}' already exists. "
+            "Delete it first if you intend to recreate it.",
+            file=sys.stderr,
+        )
         sys.exit(1)
 
-    # Resolve commit
     need_catalog = not args.commit or not args.date
     if need_catalog:
-        print(f"Fetching release details for {tag} from Red Hat Container Catalog...", flush=True)
+        print(
+            f"Fetching release details for {tag} "
+            "from Red Hat Container Catalog...",
+            flush=True,
+        )
 
     if args.commit:
         commit_sha = args.commit
         commit_source = "provided manually"
     else:
         commit_sha, commit_source = fetch_bundle_info(version)
         if not commit_sha:
-            print(f"\nERROR: Could not resolve commit SHA for {tag}.", file=sys.stderr)
-            print("       The bundle image for this version may not be in the catalog.", file=sys.stderr)
-            print("       Provide the commit manually: --commit <SHA>", file=sys.stderr)
+            print(
+                f"\nERROR: Could not resolve commit SHA for {tag}.",
+                file=sys.stderr,
+            )
+            print(
+                "       The bundle image for this version "
+                "may not be in the catalog.",
+                file=sys.stderr,
+            )
+            print(
+                "       Provide the commit manually: --commit <SHA>",
+                file=sys.stderr,
+            )
             sys.exit(1)
 
     if args.date:
@@ -300,9 +345,19 @@ def main():
         published_date = fetch_operator_push_date(version)
         date_source = "operator image push date"
         if not published_date:
-            print(f"\nERROR: Could not resolve published date for {tag}.", file=sys.stderr)
-            print("       The operator image for this version may not be in the catalog.", file=sys.stderr)
-            print("       Provide the date manually: --date YYYY-MM-DD", file=sys.stderr)
+            print(
+                f"\nERROR: Could not resolve published date for {tag}.",
+                file=sys.stderr,
+            )
+            print(
+                "       The operator image for this version "
+                "may not be in the catalog.",
+                file=sys.stderr,
+            )
+            print(
+                "       Provide the date manually: --date YYYY-MM-DD",
+                file=sys.stderr,
+            )
             sys.exit(1)
 
     # Expand to full commit SHA and verify it exists locally
@@ -343,7 +398,10 @@ def main():
         sys.exit(1)
 
     upstream_remote = _find_upstream_remote()
-    push_target = upstream_remote if upstream_remote else "git@github.com:openshift/windows-machine-config-operator.git"
+    upstream_url = (
+        "git@github.com:openshift/windows-machine-config-operator.git"
+    )
+    push_target = upstream_remote if upstream_remote else upstream_url
 
     print()
     print(f"Tag '{tag}' created. To push to the upstream repository:")