WIP: OCPBUGS-100196: pkg/clusterresources: Use RFC3339 timestamp format

[r4f4]

Description

To be more in line with annotations from other cluster resources.

Github / Jira issue: OCPBUGS-100196

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Code Improvements (Refactoring, Performance, CI upgrades, etc)
• Internal repo assets (diagrams / docs on github repo)
• This change requires a documentation update on openshift docs

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

Expected Outcome

Please describe the outcome expected from the tests.

Summary by CodeRabbit

• Bug Fixes
  • Updated timestamp formatting to use a standard UTC date-time format for generated metadata, improving consistency and compatibility.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@r4f4: This pull request references Jira Issue OCPBUGS-100196, which is invalid:

• expected the bug to target the "5.0.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Description

To be more in line with annotations from other cluster resources.

Github / Jira issue: OCPBUGS-100196

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Code Improvements (Refactoring, Performance, CI upgrades, etc)
• Internal repo assets (diagrams / docs on github repo)
• This change requires a documentation update on openshift docs

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

Expected Outcome

Please describe the outcome expected from the tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: bbefee7b-1c39-4a8a-bfb9-d0998712e684

📥 Commits

Reviewing files that changed from the base of the PR and between ea56d5a and c00f07e.

📒 Files selected for processing (1)

• internal/pkg/clusterresources/clusterresources.go

---

Walkthrough

The createdAt annotation now uses UTC RFC3339 formatting instead of RFC850 formatting.

Changes

CreatedAt annotation formatting

Layer / File(s)	Summary
Update createdAt timestamp format internal/pkg/clusterresources/clusterresources.go	generateOcMirrorAnnotations now formats the createdAt annotation with UTC RFC3339.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately reflects the main change: updating RFC3339 timestamp format in pkg/clusterresources. However, the WIP prefix and Jira reference are present despite OpenShift CI indicating the Jira issue is invalid for the target version.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The PR changes only timestamp formatting in production code; it adds or changes no tests or Ginkgo titles, and the existing test file uses static Go test names.
Test Structure And Quality	✅ Passed	No test changes are present in this PR; it modifies only a single production file. The custom check for Ginkgo test structure does not apply to non-Ginkgo test code.
Microshift Test Compatibility	✅ Passed	The commit changes only timestamp formatting in production code and adds no Ginkgo e2e tests, so MicroShift test compatibility is not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The pull request changes only timestamp formatting in clusterresources.go; it adds no Ginkgo e2e tests or other tests that could assume a multi-node cluster.
Topology-Aware Scheduling Compatibility	✅ Passed	The commit changes only the createdAt annotation from RFC850 to RFC3339; it adds no deployment, controller, node-selection, affinity, spread, replica, taint, or PDB scheduling constraint.
Ote Binary Stdout Contract	✅ Passed	The change only modifies timestamp formatting in annotation data returned by generateOcMirrorAnnotations(). The function does not write to stdout—it returns data that populates Kubernetes resource...
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The PR changes only RFC850 to RFC3339 in clusterresources.go; it adds no Ginkgo e2e tests or network connectivity.
No-Weak-Crypto	✅ Passed	The PR only changes timestamp formatting from RFC850 to RFC3339 in the generateOcMirrorAnnotations function. No weak cryptographic algorithms, custom crypto implementations, or insecure comparisons...
Container-Privileges	✅ Passed	The PR changes only a Go timestamp format; no container or Kubernetes manifest privilege settings are added or changed.
No-Sensitive-Data-In-Logs	✅ Passed	The PR changes only timestamp format in annotations containing non-sensitive metadata (tool name, timestamp, version). No passwords, tokens, API keys, PII, session IDs, hostnames, or customer data...

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: r4f4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [r4f4]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@r4f4: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.