Skip to content

feat: add skip-roxctl-scan for scratch PKO images #866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MitaliBhalla wants to merge 1 commit into
base: master
Choose a base branch
from
+15 −0
Open

feat: add skip-roxctl-scan for scratch PKO images #866

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions pipelines/docker-build-oci-ta/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,13 @@ spec:
value: pipelines/docker-build-oci-ta/pipeline.yaml
```

Optional PipelineRun params (in addition to the Konflux catalog defaults):

| Param | Default | When to set `true` |
|---|---|---|
| `skip-preflight-cert-check` | `false` | Scratch / PKO images that fail ecosystem cert preflight |
| `skip-roxctl-scan` | `false` | Scratch / PKO images that fail ACS `roxctl-scan` (no OS). Does **not** skip clamav, SAST, or RPM signature scans. Prefer this over `skip-checks`. |

### References

- https://konflux.pages.redhat.com/docs/users/patterns/centralize-pipeline-definitions.html
8 changes: 8 additions & 0 deletions pipelines/docker-build-oci-ta/pipeline.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,10 @@ spec:
default: "false"
type: string
description: Skip the preflight cert-check. This can required for scratch images. Valid values are false and true.
- name: skip-roxctl-scan
default: "false"
type: string
description: Skip ACS/roxctl-scan only (keep clamav, SAST, RPM signature, etc.). Use for FROM-scratch PKO/package images that have no OS for ACS to scan. Valid values are false and true.

@joshbranham joshbranham Aug 31, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't ACS/roxctl just gracefully handle when there is an inability to scan?

@joshbranham joshbranham Aug 31, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it's being solved with https://redhat.atlassian.net/browse/KONFLUX-15651

- name: enable-package-registry-proxy
default: 'true'
description: Use the package registry proxy when prefetching dependencies
Expand Down Expand Up @@ -305,6 +309,10 @@ spec:
operator: in
values:
- "false"
- input: $(params.skip-roxctl-scan)
operator: in
values:
- "false"
- name: ecosystem-cert-preflight-checks
params:
- name: image-url
Expand Down