MGMT-23639: image-policy override on ENABLE_KUBE_API for operator hub - #2806
Conversation
openshift-ci
Bot
added
the
size/XS
a59beb8 to
1419c71
Compare
openshift-ci
Bot
added
size/M
| NAMESPACE="${NAMESPACE:-assisted-installer}" | ||
| CM_NAME="${ASSISTED_INSTALLER_CONFIG_OVERRIDE_CM_NAME:-assisted-installer-config-override}" | ||
| ASC_NAME="${ASSISTED_INSTALLER_CONFIG_OVERRIDE_ASC_NAME:-agent}" | ||
|
|
||
| kubectl apply -f - <<EOF | ||
| apiVersion: v1 | ||
| kind: ConfigMap | ||
| metadata: | ||
| name: ${CM_NAME} | ||
| namespace: ${NAMESPACE} | ||
| data: | ||
| LOG_LEVEL: "debug" | ||
| OPENSHIFT_INSTALL_EXPERIMENTAL_DISABLE_IMAGE_POLICY: "true" | ||
| EOF | ||
|
|
||
| kubectl patch "agentserviceconfig/${ASC_NAME}" -n "${NAMESPACE}" --type=merge -p "$(cat <<PATCH | ||
| {"metadata":{"annotations":{"unsupported.agent-install.openshift.io/assisted-service-configmap":"${CM_NAME}"}}} | ||
| PATCH | ||
| )" |
There was a problem hiding this comment.
Lets move the CM logic to https://github.com/openshift/assisted-test-infra/tree/master/src/assisted_test_infra/test_infra/helper_classes/kube_helpers together with all the rest
| ("ENABLE_SKIP_MCO_REBOOT", ""), | ||
| ("ENABLE_SOFT_TIMEOUTS", ""), | ||
| # Passed to openshift-install on nodes when set (e.g. CI/nightly image policy); kind/minikube path. | ||
| ("OPENSHIFT_INSTALL_EXPERIMENTAL_DISABLE_IMAGE_POLICY", ""), |
| if [[ "${ASSISTED_INSTALLER_CONFIG_OVERRIDE:-}" != "false" ]] && { | ||
| [[ "${ASSISTED_INSTALLER_CONFIG_OVERRIDE:-false}" == "true" ]] || [[ "${ENABLE_KUBE_API:-false}" == "true" ]] |
There was a problem hiding this comment.
not sure i understand the confition
|
@andrej1991 Please fix the description and title |
1419c71 to
2a5b358
Compare
openshift-ci
Bot
added
size/L
6b5c87e to
5294a35
Compare
andrej1991
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@andrej1991: This pull request references MGMT-23639 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
058e67d to
9b0526b
Compare
|
/test e2e-metal-assisted-ha-kube-api-ipv4-4-22 |
1 similar comment
|
/test e2e-metal-assisted-ha-kube-api-ipv4-4-22 |
|
/test e2e-metal-sno-live-iso |
|
/test e2e-metal-assisted-ha-kube-api-ipv4-4-22 |
9b0526b to
313d32d
Compare
|
/retest |
c4b3749 to
925f324
Compare
|
/retest |
925f324 to
d5f099b
Compare
|
/test e2e-metal-assisted-ha-kube-api-ipv4-4-22 |
|
The job e2e-metal-assisted-ha-kube-api-ipb6-4-22 failed in the step e2e-metal-assisted-ha-kube-api-ipv6-4-22-ofcir-release, because of it could not resolve the hostname of the ofcir cluster: 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0curl: (6) Could not resolve host: ofcir.apps-int.master.ci.devcluster.openshift.com 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0curl: (6) Could not resolve host: ofcir.apps-int.master.ci.devcluster.openshift.com" It is unrelated to the current test. |
|
The job e2e-metal-assisted-ha-kube-api-ipv4-4-22 failed in the step e2e-metal-assisted-ha-kube-api-ipv4-4-22-ofcir-release, which is the post phase of the test flow. Unrelated to the current test. 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0curl: (6) Could not resolve host: ofcir.apps-int.master.ci.devcluster.openshift.com 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0curl: (6) Could not resolve host: ofcir.apps-int.master.ci.devcluster.openshift.com |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrej1991, rccrdpccl The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
/override e2e-metal-assisted-ha-kube-api-ipv4-4-22 |
|
@andrej1991: andrej1991 unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight openshift-staff-engineers openshift-sustaining-engineers. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override e2e-metal-assisted-ha-kube-api-ipv4-4-22 |
|
@rccrdpccl: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/e2e-metal-assisted-ha-kube-api-ipv4-4-22 |
|
/override ci/prow/e2e-metal-assisted-ha-kube-api-ipv6-4-22 |
|
@rccrdpccl: Overrode contexts on behalf of rccrdpccl: ci/prow/e2e-metal-assisted-ha-kube-api-ipv4-4-22 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@rccrdpccl: Overrode contexts on behalf of rccrdpccl: ci/prow/e2e-metal-assisted-ha-kube-api-ipv6-4-22 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@andrej1991: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/cherry-pick release-ocm-2.17 |
|
@andrej1991: new pull request created: #2811 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick release-ocm-2.16 |
|
/cherry-pick release-ocm-2.15 |
|
@andrej1991: new pull request created: #2812 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@andrej1991: new pull request created: #2813 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick release-ocm-2.15 |
|
@andrej1991: new pull request created: #2816 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
5 participants
Run assisted_installer_config_override only when ENABLE_KUBE_API=true
after operator deploy.sh. Unconditional invocation did not fix SNO
live-ISO; REST/operator jobs will be handled separately.
Docstring: clarify the helper is for kube-API CI (operator hub).