Add must_gather tests#943
Conversation
|
@marioferh: No Bugzilla bug is referenced in the title of this pull request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Pull Request Test Coverage Report for Build 2640
💛 - Coveralls |
|
/test e2e-gcp-operator-upgrade |
|
if this is still needed for master we will need to create a must gather test lane instead of e2e-gcp |
|
It is needed, but also good for future PR's. |
|
@marioferh we actually need this cherry pick for 4.11 and master branch here dont we ? |
| } | ||
|
|
||
| mgImage := "quay.io/openshift-kni/performance-addon-operator-must-gather" | ||
| mgTag := "4.11-snapshot" |
There was a problem hiding this comment.
notice that you are using here the 4.10 branch
Signed-off-by: Mario Fernandez <mariofer@redhat.com>
marioferh
force-pushed
the
mustgather_tests_4_10
branch
from
364cd38 to
0397579
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: marioferh The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@marioferh: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
ffromani
left a comment
ffromani
left a comment
There was a problem hiding this comment.
the general direction seems good, some questions inside
|
|
||
| It("Verify PAO cluster resources are captured", func() { | ||
| profile, _ := profiles.GetByNodeLabels(testutils.NodeSelectorLabels) | ||
| if profile == nil { |
There was a problem hiding this comment.
do we need this for anything else?
There was a problem hiding this comment.
this PR is a cherry-pick. We can continue in the original one: #943
| } | ||
| //replace peformance.yaml for profile.Name when data is generated in the node | ||
| ClusterSpecificFiles := []string{ | ||
| "cluster-scoped-resources/performance.openshift.io/performanceprofiles/performance.yaml", |
There was a problem hiding this comment.
...perhaps to construct the names here (and below)?
| }) | ||
|
|
||
| It("Verify hardware related information are captured", func() { | ||
| nodeSpecificFiles := []string{ |
There was a problem hiding this comment.
nit: I'd move this down below closer to the function using this slice. Now it is unnecessarily far from the calling site.
| if err != nil { | ||
| return err | ||
| } | ||
| if !info.IsDir() && info.Name() == "sysinfo.tgz" { |
There was a problem hiding this comment.
nit: this should probably be a constant (in a must-gather package?)
| return nil | ||
| } | ||
|
|
||
| func Untar(root string, snapshotName string) error { |
There was a problem hiding this comment.
I wonder if we can/should reuse ghw code here
| } | ||
|
|
||
| mgImage := "quay.io/openshift-kni/performance-addon-operator-must-gather" | ||
| mgTag := "4.10-snapshot" |
There was a problem hiding this comment.
should this be constructed from PAO version, or, in general, NOT be hardcoded?
|
scratch my comments, I didn't notice this is a cherry pick. |
4 participants
Add must_gather tests, manual cherry-pick from NTO openshift/cluster-node-tuning-operator#442
Signed-off-by: Mario Fernandez mariofer@redhat.com