Skip to content

Set gRPC security interceptor to highest priority #5940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aparajita31pandey wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Set gRPC security interceptor to highest priority #5940

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
aa8c842
Set gRPC security interceptor to highest priority
dependabot[bot] Oct 7, 2024
0491808
add test coverage for SecurityGrpcFilter interceptor ordering
aparajita31pandey Feb 3, 2026
8a05815
Merge branch 'main' into gRPCFilter
aparajita31pandey Feb 4, 2026
d48b79b
Add ChangeLog Entry
aparajita31pandey Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/org/opensearch/security/filter/SecurityGrpcFilter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ public List<OrderedGrpcInterceptor> getOrderedGrpcInterceptors(ThreadContext thr

@Override
public int order() {
return 0;
return Integer.MIN_VALUE;
}

@Override
Expand Down
16 changes: 16 additions & 0 deletions src/test/java/org/opensearch/security/filter/SecurityGrpcFilterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,4 +94,20 @@ public void testNormalConfigurationReturnsInterceptor() {
assertTrue(e.getMessage().contains("GuiceHolder") || e instanceof NullPointerException);
}
}

@Test
public void testInterceptorOrderIsMinValue() {
Settings settings = Settings.builder().put(OpenSearchSecuritySSLPlugin.CLIENT_TYPE, "node").build();

securityGrpcFilter.initNodeSettings(settings);

List<GrpcInterceptorProvider.OrderedGrpcInterceptor> interceptors = securityGrpcFilter.getOrderedGrpcInterceptors(threadContext);

assertEquals("Should return exactly one interceptor", 1, interceptors.size());
assertEquals(
"Security interceptor should have highest priority (Integer.MIN_VALUE)",
Integer.MIN_VALUE,
interceptors.get(0).order()
);
}
}
Loading