-
Notifications
You must be signed in to change notification settings - Fork 1.1k
fix(server): configure egress sidecar readiness timeout #1522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -751,6 +751,14 @@ class EgressConfig(BaseModel): | |
| "(e.g. IPv4-only CNI or experimenting with IPv6 egress despite gaps)." | ||
| ), | ||
| ) | ||
| timeout_seconds: float = Field( | ||
| default=30.0, | ||
| gt=0, | ||
|
Comment on lines
+754
to
+756
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
When AGENTS.md reference: server/AGENTS.md:L42-L42 Useful? React with 👍 / 👎. |
||
| description=( | ||
| "Maximum time in seconds to wait for the egress sidecar health endpoint " | ||
| "to become ready in Docker runtime." | ||
| ), | ||
| ) | ||
|
|
||
|
|
||
| class RuntimeConfig(BaseModel): | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit (non-blocking):
timeout_secondsis a bit generic — the[egress]section may later grow other timeouts (e.g., per-request API timeouts), and this one specifically bounds the readiness wait. Since the PR is not merged yet, renaming is nearly free. Something likeready_timeout_seconds(matches_wait_for_egress_sidecar_ready) orreadiness_timeout_seconds(K8s readinessProbe terminology) would make the intent explicit. If renamed, remember to update networking.py,server/configuration.md, both example TOMLs, docker-compose.example.yaml, and the test assertions.