fix(kubernetes): preserve snapshot source content - #1508
Draft
prazgaitis wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nerdctl pull --all-platformsandnerdctl push --all-platforms.nerdctl inspectwithout being confused by interleaved network-namespace warnings.Testing
go test ./cmd/image-committer/...)linux/arm64image build)The e2e test ran on k3d against the exact image-committer flow:
runAsNonRoot, UID 1000, dropped capabilities, andRuntimeDefaultseccomp profile were preserved.Trivy 0.66 reported 0 Critical findings. The Alpine OS and OpenSandbox binary reported 0 High findings. The bundled latest nerdctl 2.3.5 binary reports two High findings in upstream Go dependencies (
golang.org/x/textandgoogle.golang.org/grpc); eliminating those before nerdctl publishes a refreshed release would require maintaining a custom nerdctl source build.Breaking Changes
Checklist