fix(server): pause egress sidecar with sandbox - #1441
Open
luppyw wants to merge 1 commit into
Open
Conversation
luppyw
requested review from
Generalwin,
Pangjiping,
hittyt,
jwx0925 and
ninan-nn
as code owners
August 4, 2026 13:14
This was referenced Aug 4, 2026
Contributor
Author
|
@Pangjiping Could you please review this PR when you have time? If the changes look correct and the required checks pass, would you be willing to merge it? I will address any requested changes promptly. 简体中文@Pangjiping 方便时能否帮忙审核一下这个 PR?如果修改没有问题且必要检查通过,麻烦帮忙合并;如果需要调整,我会及时跟进。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1422
Testing
Not run (explain why)
Unit tests
Integration tests
e2e / manual verification
cd server && python -m pytest -p no:cacheprovider -q(1319 passed)cd server && ruff checkcd docs && corepack pnpm docs:buildVerified against real Docker containers sharing the sidecar network namespace: both containers paused together and returned to running after resume.
Pyright remains non-clean with 55 diagnostics outside the new lifecycle paths, primarily in generated schema calls and mixin host attributes.
Breaking Changes
Checklist