Skip to content

fix(server): pause egress sidecar with sandbox - #1441

Open
luppyw wants to merge 1 commit into
opensandbox-group:mainfrom
luppyw:fix/1422-egress-pause-resume
Open

fix(server): pause egress sidecar with sandbox#1441
luppyw wants to merge 1 commit into
opensandbox-group:mainfrom
luppyw:fix/1422-egress-pause-resume

Conversation

@luppyw

@luppyw luppyw commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Pause the Docker sandbox container before its egress sidecar and resume the sidecar before the sandbox container so the complete data plane follows the sandbox lifecycle.
  • Fail closed when an expected sidecar is missing, compensate for partial lifecycle failures, and preserve existing behavior for sandboxes without a sidecar.
  • Add focused lifecycle tests and document the Docker pause/resume ordering.

Fixes #1422

Testing

  • Not run (explain why)

  • Unit tests

  • Integration tests

  • e2e / manual verification

  • cd server && python -m pytest -p no:cacheprovider -q (1319 passed)

  • cd server && ruff check

  • cd docs && corepack pnpm docs:build

  • Verified against real Docker containers sharing the sidecar network namespace: both containers paused together and returned to running after resume.

Pyright remains non-clean with 55 diagnostics outside the new lifecycle paths, primarily in generated schema calls and mixin host attributes.

Breaking Changes

  • None
  • Yes (describe impact and migration path)

Checklist

  • Linked Issue or clearly described motivation
  • Added/updated docs (if needed)
  • Added/updated tests (if needed)
  • Security impact considered
  • Backward compatibility considered

@github-actions github-actions Bot added component/server documentation Improvements or additions to documentation size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 4, 2026
@luppyw

luppyw commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

@Pangjiping Could you please review this PR when you have time? If the changes look correct and the required checks pass, would you be willing to merge it? I will address any requested changes promptly.

简体中文

@Pangjiping 方便时能否帮忙审核一下这个 PR?如果修改没有问题且必要检查通过,麻烦帮忙合并;如果需要调整,我会及时跟进。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/server documentation Improvements or additions to documentation size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pause and resume the egress sidecar together with the sandbox in Docker runtime

1 participant