Fix crash when a job's tasks all end up canceled

AGENTS.md

@@ -82,7 +82,7 @@ The job status is derived from its tasks via `post_process()`. The evaluation pr
 1. Any PENDING task → job becomes PENDING (unless job is CANCELING)
 2. Any IN_PROGRESS task → job becomes IN_PROGRESS (unless job is CANCELING)
 3. If job was `CANCELING` → job becomes `CANCELED`
-4. Otherwise the job is finished and its final status is computed from the combination of `SUCCESS`, `WARNING`, and `FAILURE` tasks
+4. Otherwise the job is finished and its final status is computed from the combination of `SUCCESS`, `WARNING`, and `FAILURE` tasks. If none of those are present but canceled tasks are, the job becomes `CANCELED`
 
 ### Job Actions
 

adit/core/models.py

@@ -291,6 +291,7 @@ def post_process(self, suppress_email=False) -> bool:
         has_success = self.tasks.filter(status=DicomTask.Status.SUCCESS).exists()
         has_warning = self.tasks.filter(status=DicomTask.Status.WARNING).exists()
         has_failure = self.tasks.filter(status=DicomTask.Status.FAILURE).exists()
+        has_canceled = self.tasks.filter(status=DicomTask.Status.CANCELED).exists()
 
         if has_success and not has_warning and not has_failure:
             self.status = DicomJob.Status.SUCCESS
@@ -307,8 +308,11 @@ def post_process(self, suppress_email=False) -> bool:
         elif has_failure:
             self.status = DicomJob.Status.FAILURE
             self.message = "All tasks failed."
+        elif has_canceled:
+            self.status = DicomJob.Status.CANCELED
+            self.message = "All tasks were canceled."
         else:
-            # at least one of success, warnings or failures must be > 0
+            # at least one of success, warnings, failures or cancellations must be > 0
             raise AssertionError(f"Invalid task status list of {self}.")
 
         self.end = timezone.now()

adit/core/tests/test_models.py

@@ -168,6 +168,38 @@ def test_job_post_process_canceling_status(self):
         assert job.status == DicomJob.Status.CANCELED
         assert job.end is None
 
+    @pytest.mark.django_db
+    def test_job_post_process_all_tasks_canceled(self):
+        # A job that is no longer CANCELING (so it reaches the final evaluation)
+        # but whose tasks all ended up canceled, e.g. after killing them from the
+        # admin. Without a canceled branch this raised an AssertionError.
+        job = ExampleTransferJobFactory.create(status=DicomJob.Status.PENDING)
+
+        ExampleTransferTaskFactory.create(job=job, status=DicomTask.Status.CANCELED)
+        ExampleTransferTaskFactory.create(job=job, status=DicomTask.Status.CANCELED)
+
+        result = job.post_process()
+        job.refresh_from_db()
+
+        assert result is True
+        assert job.status == DicomJob.Status.CANCELED
+        assert job.message == "All tasks were canceled."
+        assert job.end is not None
+
+    @pytest.mark.django_db
+    def test_job_post_process_canceled_task_does_not_mask_failure(self):
+        # A canceled task alongside a failed one must still resolve to FAILURE;
+        # the canceled branch only applies when nothing else is present.
+        job = ExampleTransferJobFactory.create(status=DicomJob.Status.PENDING)
+
+        ExampleTransferTaskFactory.create(job=job, status=DicomTask.Status.CANCELED)
+        ExampleTransferTaskFactory.create(job=job, status=DicomTask.Status.FAILURE)
+
+        job.post_process()
+        job.refresh_from_db()
+
+        assert job.status == DicomJob.Status.FAILURE
+
     @pytest.mark.django_db
     @time_machine.travel("2025-01-15 14:30:00+00:00")
     def test_job_timezone_correctness(self):