Skip to content

added default cancel message #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Lucius1274 wants to merge 2 commits into from
Closed

added default cancel message #290

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
772a23e
added cancel message
Lucius1274 Jan 28, 2026
724803a
Merge branch 'main' into default_cancel_message
Lucius1274 Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion adit/core/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ def post(self, request: AuthenticatedHttpRequest, *args, **kwargs) -> HttpRespon
queued_job_id = dicom_task.queued_job_id
if queued_job_id is not None:
app.job_manager.cancel_job_by_id(queued_job_id, delete_job=True)
tasks.update(status=DicomTask.Status.CANCELED)
tasks.update(status=DicomTask.Status.CANCELED, message="Task manually canceled")

@gemini-code-assist gemini-code-assist Bot Jan 28, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While adding a cancellation message is a good idea, hardcoding the string here is not ideal for maintainability. It would be better to define this message as a constant on the DicomTask model (e.g., DicomTask.MANUALLY_CANCELED_MESSAGE) and reference it here. This makes the message reusable and easier to manage if it needs to be changed in the future.

if job.tasks.filter(status=DicomTask.Status.IN_PROGRESS).exists():
job.status = DicomJob.Status.CANCELING
Expand Down