0.31 backports#99
Draft
microstudi wants to merge 85 commits into
Draft
Conversation
commit 6cc62f36552c2ab27d76df75d5d339320f85d9a7 Merge: 31e09c7 82c93ce Author: Ivan Vergés <ivan@pokecode.net> Date: Tue Oct 21 10:37:46 2025 +0200 Merge branch 'develop' into feature/elections-census-check-before-start commit 31e09c7 Author: Anna Topalidi <t.opalidisanna@gmail.com> Date: Tue Oct 21 07:10:47 2025 +0200 fix linter commit 85f1a25 Author: Anna Topalidi <t.opalidisanna@gmail.com> Date: Mon Oct 20 22:08:55 2025 +0200 Allow users to check if they can vote before the election starts commit e503bec Author: Anna Topalidi <t.opalidisanna@gmail.com> Date: Fri Oct 10 15:36:16 2025 +0200 xhange controller, add tests commit 408a174 Author: Anna Topalidi <t.opalidisanna@gmail.com> Date: Fri Oct 10 14:52:00 2025 +0200 change text commit a1ed690 Author: Anna Topalidi <t.opalidisanna@gmail.com> Date: Fri Oct 10 13:55:51 2025 +0200 change test commit 242f0a6 Author: Anna Topalidi <t.opalidisanna@gmail.com> Date: Fri Oct 10 13:33:59 2025 +0200 add check before start
commit 0ddc2b4df70d72348aefab4d1ed2d5f4778228a3 Merge: ad11ec8 82c93ce Author: Ivan Vergés <ivan@pokecode.net> Date: Tue Oct 21 10:40:41 2025 +0200 Merge branch 'develop' into feature/elections-display-question-description commit ad11ec8 Author: Anna Topalidi <t.opalidisanna@gmail.com> Date: Tue Oct 21 09:43:20 2025 +0200 fix title commit 0136d42 Author: Anna Topalidi <t.opalidisanna@gmail.com> Date: Tue Oct 21 08:56:39 2025 +0200 fix tests commit 2523af2 Author: Anna Topalidi <t.opalidisanna@gmail.com> Date: Mon Oct 20 14:44:11 2025 +0200 fix question_description commit 8dfe2c1 Author: Anna Topalidi <t.opalidisanna@gmail.com> Date: Thu Oct 9 11:51:33 2025 +0200 display question description
commit 328e89ce35525d8d3efdbff7a82d01ea24c578f8 Merge: a0d1ea9 8fb3f92 Author: Ivan Vergés <ivan@pokecode.net> Date: Tue Oct 21 12:32:05 2025 +0200 Merge branch 'develop' into feature/elections-max-choices-limit commit 8fb3f92 Author: Alexandru Emil Lupu <contact@alecslupu.ro> Date: Tue Oct 21 12:52:21 2025 +0300 Fix ActiveRecord::AssociationTypeMismatch error in AddDemocraticQualityStaticPage (decidim#15399) commit 3f8a04f Author: Alexandru Emil Lupu <contact@alecslupu.ro> Date: Tue Oct 21 11:35:30 2025 +0300 Fix expiring Cloud Storage tokens (decidim#15005) * Fix expiring Cloud Storage tokens * Fix spellcheck issues * 📝 qlty fmt * Add public env variable * Revert qlty.toml * Revert toml * Apply suggestions from code review Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Fix liniting issues * Trigger pipeline --------- Co-authored-by: qltysh[bot] <168846912+qltysh[bot]@users.noreply.github.com> Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> commit a0d1ea9 Merge: e1952f9 e34bce9 Author: Anna Topalidi <t.opalidisanna@gmail.com> Date: Thu Oct 9 10:11:13 2025 +0200 Merge branch 'develop' into feature/elections-max-choices-limit commit e1952f9 Author: Anna Topalidi <t.opalidisanna@gmail.com> Date: Thu Oct 9 09:54:36 2025 +0200 fix test commit 85e53d2 Author: Anna Topalidi <t.opalidisanna@gmail.com> Date: Wed Oct 8 17:20:28 2025 +0200 fix test commit abe20bc Author: Anna Topalidi <t.opalidisanna@gmail.com> Date: Wed Oct 8 16:19:11 2025 +0200 fix linter commit cf06937 Author: Anna Topalidi <t.opalidisanna@gmail.com> Date: Tue Oct 7 15:24:39 2025 +0200 add max choices limit
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…ecidim#16159) * JS import configured to select states based on component * Route configured for collection on proposal import new * Imported js entry point of import_proposals. * Configured a new iteration from select on the component origin within the form * Created component_states method within the import controller * Updated some lint issues with the JS script * Updated import controller to retrieve the origin_id instead of component id * Moved the proposals_merge resource route. * Added attribute to select states based on the selected component * Added selectedStates which parses the selected states based on the component * Removed validate :valid_states because pluck token wasn't reterving states on its own componet not from that selected * Fixed the tercary operator on the selected states checkbox * Aligned the method call on the new form to fix lint error * not answered missing from the component states maped to be selected from the componet * Extracted the enforce_permissions method to component_states to parse users who dont have permissions to run the import actions * clean up of unused methods within the proposal import form * Updated object that retrieves the states via the proposal_import * Escaped the html by interpolating the state.token and state.title within the script to encode all handles * reverted private method of valid_states checking the proposal state and plucking the not_answered state server side validation * System spec added to check for dynamically added states from origin component * Updated spec to account for custom states to be detected in drop down * refactored the proposal import change to import from a stimulus controller * modified the new page to call the data attribute of the dynamic states * update to controller based on lint errors * refactored to use the mordern way of stimulus of calling the controller and an absolute path * jS docs added to the controller fetching the states dynamically
* add export button * add serializer * add specs * fix sql & export data --------- Co-authored-by: Ivan Vergés <ivan@pokecode.net>
* New translations en.yml (Catalan) [ci skip] * New translations en.yml (Swedish) [ci skip] * New translations en.yml (Catalan, Algherese) [ci skip] * New translations en.yml (Swedish) [ci skip] * New translations en.yml (French, Canada) [ci skip] * New translations en.yml (Catalan, Algherese) [ci skip] * New translations en.yml (French, Canada) [ci skip] * New translations en.yml (French, Canada) [ci skip] * New translations en.yml (Swedish) [ci skip] * New translations en.yml (Catalan, Algherese) [ci skip]
…idim#16905) * Check for existing user in "show email" form * Handled non-existing user case for show_email * Run linter * Fixed linter issue * Small refactor * Removed blank line * Apply review recommendation * Added success case in test file --------- Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro> * Apply suggestion from @alecslupu --------- Co-authored-by: andra-panaite <135139066+andra-panaite@users.noreply.github.com>
…dim#16915) * Parametrize Validator version * Add default value * Use vars. instead of env Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
…ecidim#16921) * Fix the pages component duplicate/copy hook name * Add specs * Fix AI nitpick Co-authored-by: Antti Hukkanen <antti.hukkanen@mainiotech.fi>
…0.31 (decidim#16923) Co-authored-by: Masayoshi Takahashi <takahashim@users.noreply.github.com>
…cate Spaces forms' to v0.31 (decidim#16939) * Remove "Duplicate landing page content blocks" checkbox from Duplicate Assembly form * Remove "Duplicate landing page content blocks" checkbox from Duplicate Process form * Remove leftover from Pages spec Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
Co-authored-by: Anna Topalidi <60363870+antopalidi@users.noreply.github.com> Co-authored-by: Ivan Vergés <ivan@pokecode.net>
…0.31 (decidim#16950) Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
…t' to v0.31 (decidim#16956) * Fix URLs for service workers cache * Remove unecessary unconditional import of service worker JS file Mind that the conditional check if SW should be added is happening at decidim-core/app/views/layouts/decidim/_decidim_javascript.html.erb Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
…ecidim#16963) * fix: add appropriate roles on header and footer * fix: add role main in admin and system * fix: add missing role main in decidim-core views * fix: add missing role main in decidim-conferences views * fix: add missing role main in initiatives and processes views * fix: add missign role main in views * fix: remove unrelated code * fix: add missing role banner in views * fix: remove duplicated role banner * refactor: update roles after coderabbit analysis * Remove unecessary role="banner" attributes * Revert "fix: remove unrelated code" This reverts commit a3b9b3f. --------- Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> Co-authored-by: stephanie rousset <strabon@club-internet.fr> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
…m#16975) * Show number of votes in transparent space * Show number of votes in transparent space * Update decidim-proposals/spec/system/transparent_space_proposal_spec.rb Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Change from .is_transparent? to .try(:transparent?) * Lint * Update decidim-proposals/spec/system/transparent_space_proposal_spec.rb Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Refactor in a new cell * Update decidim-proposals/spec/system/transparent_space_proposal_spec.rb Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Fix failing specs * Fix additional specs --------- Co-authored-by: Fran Bolívar (FBO) <francisco.bolivar@nazaries.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
…v0.31 (decidim#16987) * Fix exception when user is already invited in meetings * Fix exception when user is already invited * Alternate fix * Fix spec description * Apply suggestions from code review Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> --------- Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Fix specs * Fix failing specs --------- Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro> Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
…published elections' to v0.31 (decidim#16998) * prevent start date validation on manual start when editing published elections * address review Co-authored-by: Ivan Vergés <ivan@pokecode.net>
… HTML context' to v0.31 (decidim#16996) * refactor renderers to take into account html context * refactor blob/resource renderers * spelling * address review * address review * end statement * remove comment Co-authored-by: Ivan Vergés <ivan@pokecode.net>
* New translations en.yml (Basque) [ci skip] * New translations en.yml (Basque) [ci skip] * New translations en.yml (Italian) [ci skip] * New translations en.yml (Basque) [ci skip] * New translations en.yml (Basque) [ci skip] * New translations en.yml (Slovak) [ci skip] * New translations en.yml (Italian) [ci skip] * New translations en.yml (Czech) [ci skip] * New translations en.yml (Portuguese, Brazilian) [ci skip] * New translations en.yml (Romanian) [ci skip] * New translations en.yml (Arabic) [ci skip] * New translations en.yml (Bulgarian) [ci skip] * New translations en.yml (German) [ci skip] * New translations en.yml (Greek) [ci skip] * New translations en.yml (Basque) [ci skip] * New translations en.yml (Finnish) [ci skip] * New translations en.yml (Hungarian) [ci skip] * New translations en.yml (Japanese) [ci skip] * New translations en.yml (Lithuanian) [ci skip] * New translations en.yml (Dutch) [ci skip] * New translations en.yml (Norwegian) [ci skip] * New translations en.yml (Polish) [ci skip] * New translations en.yml (Portuguese) [ci skip] * New translations en.yml (Swedish) [ci skip] * New translations en.yml (Turkish) [ci skip] * New translations en.yml (Chinese Simplified) [ci skip] * New translations en.yml (Chinese Traditional) [ci skip] * New translations en.yml (Galician) [ci skip] * New translations en.yml (Indonesian) [ci skip] * New translations en.yml (Latvian) [ci skip] * New translations en.yml (Luxembourgish) [ci skip] * New translations en.yml (Finnish (plain)) [ci skip] * New translations en.yml (Russian with many plural form) [ci skip] * New translations en.yml (Basque) [ci skip] * New translations en.yml (Basque) [ci skip] * New translations en.yml (Slovak) [ci skip] * New translations en.yml (Basque) [ci skip] * New translations en.yml (Basque) [ci skip] * New translations en.yml (Romanian) [ci skip] * New translations en.yml (French) [ci skip] * New translations en.yml (Spanish) [ci skip] * New translations en.yml (Bulgarian) [ci skip] * New translations en.yml (Catalan) [ci skip] * New translations en.yml (Czech) [ci skip] * New translations en.yml (German) [ci skip] * New translations en.yml (Basque) [ci skip] * New translations en.yml (Finnish) [ci skip] * New translations en.yml (Hungarian) [ci skip] * New translations en.yml (Italian) [ci skip] * New translations en.yml (Japanese) [ci skip] * New translations en.yml (Lithuanian) [ci skip] * New translations en.yml (Dutch) [ci skip] * New translations en.yml (Norwegian) [ci skip] * New translations en.yml (Polish) [ci skip] * New translations en.yml (Portuguese) [ci skip] * New translations en.yml (Swedish) [ci skip] * New translations en.yml (Chinese Traditional) [ci skip] * New translations en.yml (Galician) [ci skip] * New translations en.yml (Portuguese, Brazilian) [ci skip] * New translations en.yml (Spanish, Mexico) [ci skip] * New translations en.yml (French, Canada) [ci skip] * New translations en.yml (Spanish, Paraguay) [ci skip] * New translations en.yml (Finnish (plain)) [ci skip] * New translations en.yml (Catalan, Algherese) [ci skip] * New translations en.yml (Basque) [ci skip] * New translations en.yml (Basque) [ci skip] * New translations en.yml (Basque) [ci skip] * New translations en.yml (Basque) [ci skip] * New translations en.yml (Basque) [ci skip] * New translations en.yml (Finnish) [ci skip] * New translations en.yml (Basque) [ci skip] * New translations en.yml (Basque) [ci skip] * New translations en.yml (Finnish) [ci skip] * New translations en.yml (Basque) [ci skip] * New translations en.yml (Basque) [ci skip] * New translations en.yml (Catalan) [ci skip] * New translations en.yml (Basque) [ci skip] * New translations en.yml (Catalan) [ci skip] * New translations en.yml (Basque) [ci skip] * New translations en.yml (Basque) [ci skip] * New translations en.yml (Basque) [ci skip] * New translations en.yml (Basque) [ci skip] * New translations en.yml (Basque) [ci skip] * New translations en.yml (German) [ci skip] * New translations en.yml (French) [ci skip] * New translations en.yml (French) [ci skip] * New translations en.yml (Spanish) [ci skip] * New translations en.yml (Catalan) [ci skip] * New translations en.yml (German) [ci skip] * New translations en.yml (Basque) [ci skip] * New translations en.yml (Finnish) [ci skip] * New translations en.yml (Spanish, Mexico) [ci skip] * New translations en.yml (French, Canada) [ci skip] * New translations en.yml (Spanish, Paraguay) [ci skip] * New translations en.yml (Finnish (plain)) [ci skip] * New translations en.yml (Catalan, Algherese) [ci skip] * New translations en.yml (Basque) [ci skip] * New translations en.yml (Basque) [ci skip] * New translations en.yml (Basque) [ci skip] * New translations en.yml (Basque) [ci skip] * New translations en.yml (Portuguese, Brazilian) [ci skip] * New translations en.yml (Basque) [ci skip] * New translations en.yml (Portuguese, Brazilian) [ci skip] * New translations en.yml (Czech) [ci skip] * New translations en.yml (Finnish) [ci skip] * New translations en.yml (Czech) [ci skip] * New translations en.yml (Czech) [ci skip] * New translations en.yml (Finnish (plain)) [ci skip] * New translations en.yml (Basque) [ci skip] * New translations en.yml (Swedish) [ci skip]
* Fix column sorting in admin tables * fix sortings, add tests * Fix duplicated meetings in admin list when ordering by taxonomies * Fix sorting users by moderation report count * fix minings * Fix failing specs --------- Co-authored-by: Anna Topalidi <60363870+antopalidi@users.noreply.github.com>
…6973) * Fix locale setup in devise controllers * fix locale setup in devise controllers * add words * use around action * Apply suggestions from code review Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Ivan Vergés <ivan@pokecode.net> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
* Fix eslint plugin import usage * Fix eslint plugin import usage * Fix imports * Change config strategy * Run npm install * add sortitions to modules path
…31 (decidim#17008) Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
…' to v0.31 (decidim#17015) * make import of assemblies/processes attachments more robust * test creation of attachment collections * fix rubocop * change unless for if Co-authored-by: David <david@pokecode.net>
…paces' to v0.31 (decidim#17006) * Fix unique constraint in space commands caused by deleted spaces * Fix Duplicate space command to include deleted spaces * Format specs * Fix create and update the spaces * Fix import forms * Apply suggestions from code review Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Align with latest develop branch --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Fix failing specs * Fix aditional specs * Fix aditional specs * Fix import * apply copilot recommendation --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
…31 (decidim#17021) * Replace tribute javascript with resource mention UI Prompt: """ Replace the TributeJS current usage with the "@tiptap/extension-mention" that is being used for Resource Mentions features. This should also work for cases where this is being called on contexts that doesn't have any TipTap editor (for instance, on the Comments form). The design should us the same compact suggestion style as TipTap mention/resource mentions for having a consistent behavior/UI across contexts. """ Assisted-By: GPT-5.3-Codex (OpenCode) <andreslucena+ai@users.noreply.github.com> * Fix the display of the UI Prompt: """ Fix the display of the autocomplete menu so it displays as the resource mention feature. The options should be shown next to the character that starts this feature ("@" character). """ Assisted-By: GPT-5.3-Codex (OpenCode) <andreslucena+ai@users.noreply.github.com> * Add avatar Prompt: """ Add the avatar of the participant next to its name in the options menu """ Assisted-By: GPT-5.3-Codex (OpenCode) <andreslucena+ai@users.noreply.github.com> * Replace tribute word usage in examples * Fix eslint offenses (automatically) * Add esilnt ignore rule Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
…31 (decidim#17030) * Handled non-existing user case for show_email * Run linter * Fixed linter issue * Small refactor * Removed blank line * Apply review recommendation * Check for user existence in officialize form * Added success case in test file * Added test cases --------- Co-authored-by: andra-panaite <135139066+andra-panaite@users.noreply.github.com> Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
…sions' to v0.31 (decidim#17037) * change .map to use .filter_map * add spec check Co-authored-by: Elvia Benedith <116598037+ElviaBth@users.noreply.github.com>
…dim#17039) * Fix flaky on generators bundler (multijson) * Add multi_json gem for GCS provider Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
…im#17046) Co-authored-by: Antti Hukkanen <antti.hukkanen@mainiotech.fi>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOT TO MERGE