Skip to content

Add json-pointer format to statementPointerTarget #758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
StephenAbbott wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add json-pointer format to statementPointerTarget #758

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion schema/statement.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,8 @@
"statementPointerTarget": {
"title": "Statement Fragment Pointer",
"description": "An RFC6901 JSON Pointer (https://tools.ietf.org/html/rfc6901) describing the target fragment of the statement that this Annotation applies to, starting from the root of the Statement. An empty string (\"\") indicates that the Annotation applies to the whole Statement.",
"type": "string"
"type": "string",
"format": "json-pointer"
},
"creationDate": {
"title": "Creation Date",
Expand Down
1 change: 1 addition & 0 deletions tests/data/invalid-statements/expected_errors.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ person_names_fullName_missing.json,required,$[0].recordDetails.names[0],fullName
person_taxResidencies_no_object.json,type,$[0].recordDetails.taxResidencies,taxResidencies
person_addresses_no_array.json,type,$[0].recordDetails.addresses,addresses
statement_annotations_statementPointerTarget_type.json,type,$[0].annotations[0].statementPointerTarget,statementPointerTarget
statement_annotations_statementPointerTarget_format.json,format,$[0].annotations[0].statementPointerTarget,statementPointerTarget
entity_address_not_string.json,type,$[0].recordDetails.addresses[0].address,address
entity_postcode_not_string.json,type,$[0].recordDetails.addresses[0].postCode,postCode
entity_address_country_name_not_string.json,type,$[0].recordDetails.addresses[0].country.name,name
Expand Down
21 changes: 21 additions & 0 deletions tests/data/invalid-statements/statement_annotations_statementPointerTarget_format.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
[
{
"statementId": "2f7bf9370f1254068e5e946df067d07d",
"declarationSubject": "xyz",
"statementDate": "2017-11-18",
"annotations": [
{
"statementPointerTarget": "recordDetails/interestedParty",
"motivation": "identifying"
}
],
"recordId": "123",
"recordType": "entity",
"recordDetails": {
"entityType": {
"type": "unknownEntity"
},
"isComponent": false
}
}
]
Loading