feat(i18n): change wording for zh-TW by yrctw · Pull Request #1424 · openng-org/optimus-ui

yrctw · 2026-08-02T04:45:55Z

Description

Modified to be a common expression used by local Taiwanese people.

Summary by CodeRabbit

Localization
- Updated Traditional Chinese wording across rules, dates, filters, calendars, files, selections, accessibility, navigation, and zoom messages.
- Standardized terminology for clearer and more consistent Traditional Chinese translations.

vercel · 2026-08-02T04:46:01Z

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments

Project	Deployment	Actions	Updated
next-optimus-ui	Skipped		Nov 11, 2026 6:56am UTC
optimus-ui	Skipped		Nov 11, 2026 6:56am UTC

Copilot

Pull request overview

Updates the Traditional Chinese (Taiwan) locale strings to use more common local wording, improving the UI’s tone and terminology consistency for zh-TW users.

Changes:

Refined multiple general UI action/label translations (e.g., accept/apply/filter, empty-state messages).
Adjusted date/time and navigation-related wording (e.g., next/prev year, selection message).
Updated several ARIA/accessibility labels to align with revised terminology (e.g., “過濾”, “列”, “檢視”).

Suppressed comments (1)

packages/optimus-ui-locale/src/zh-TW.json:128

startsWith is the string-match operator label (“Starts with”). The new translation “開始於” reads like “starts at (a time/place)” and can be misleading for text matching. Consider wording that explicitly means “starts with”, consistent with the operator semantics.

    "startsWith": "開始於",

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

yrctw · 2026-08-04T10:18:23Z

+    "emptyMessage": "沒有可用項目",
+    "emptySearchMessage": "沒有相關搜尋結果",
+    "emptySelectionMessage": "沒有選取的項目",
+    "endsWith": "結束於",


resolved at commit 30e3034

endsWith is the string-match operator label (“Ends with”). The new translation “結束於” reads like “ends at (a time/place)” and can be misleading for text matching. Consider wording that explicitly means “ends with”, consistent with the operator semantics. This issue also appears on line 128 of the same file.

vercel · 2026-08-04T10:15:29Z

@yrctw is attempting to deploy a commit to the Gerome Grignon Team on Vercel.

A member of the Team first needs to authorize it.

geromegrignon · 2026-08-04T12:03:57Z

This PR will need to be reviewed by a native Taiwanese speaker because Claude alone provided me with feedback about inconsistent terms compared to the other languages than i can review myself.

Concerns worth raising on the PR

nextYear / prevYear → 明年 / 去年 — I'd call this a regression.

datepicker.ts:1288 uses nextYear as the aria label for the forward-navigation button when the picker is in month view. It means "advance the displayed year," not "the year after today." 明年/去年 are anchored to the real current year, so a user browsing 1985 hears "next year / last year." The old 下一年/上一年 was correct. Ask for a revert on these two.

accept / reject → 接受 / 拒絕 — visible behavior change, not just wording.

These aren't aria labels; they're the default button labels in ConfirmDialog and ConfirmPopup. The English source is "Yes" / "No", and 是/否 mirrored that. 接受/拒絕 changes what every existing zh-TW confirm dialog renders, and reads oddly for a "Are you sure you want to delete?" prompt. aria.trueLabel/falseLabel are still 是/否, so the file is now internally inconsistent on the same two words. I'd push back or split this out.

篩選 → 過濾 — the most contentious change, and the largest (10 keys).

For data-grid filtering, 篩選 is the established Taiwan convention (it's what Microsoft Office and Apple ship in zh-TW). 過濾 is understood but leans toward "filter out" and is more common in mainland-influenced technical writing — which is ironic given the PR's stated goal. The author applied it consistently, so it's not sloppy, but this one really needs a second native zh-TW reviewer before merge.

Minor drift from the English source

cancelEdit / saveEdit ("Cancel Edit" / "Save Edit") became 取消變更 / 儲存變更 ("cancel/save changes"). Fine in isolation, but it's re-scoping the string rather than translating it. And emptyFilterMessage → 沒有符合過濾條件的結果 is 10 characters, noticeably longer than the old 6 — could wrap in narrow dropdowns.

- accroding to datePicker, nextYear / prevYear，上一年/下一年 is better wording than 去年/明年 - accept / reject revert back to yes (是) / no (否) meaning - I came up with the Thunderbird Mail app, the filter function is named 篩選 rather than 過濾, so I reverted it back - emptyFilterMessage and emptySearchMessage can be narrow to the same "沒有符合的結果" but it will lost the difference of filter and search

yrctw · 2026-08-04T14:39:07Z

accroding to datePicker, nextYear / prevYear，上一年/下一年 is better wording than 去年/明年
accept / reject revert back to yes (是) / no (否) meaning
I came up with the Thunderbird Mail app, the filter function is named 篩選 rather than 過濾, so I reverted it back
emptyFilterMessage and emptySearchMessage can be narrow to the same "沒有符合的結果" but it will lost the difference of filter and search

coderabbitai · 2026-09-03T12:17:46Z

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

Run configuration

Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: bd8b570b-1918-496f-8a89-c7e6f98a1169

Commits

Reviewing files that changed from the base of the PR and between 0936f2c and 801e39a.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

Trigger review

No actionable comments were generated in the recent review.

Walkthrough

The PR revises Traditional Chinese localization wording across rule, date, calendar, file, selection, accessibility, navigation, row, and zoom-related messages.

Changes: Traditional Chinese locale wording

Layer / File(s)	Summary
Translation terminology updates `packages/optimus-ui-locale/src/zh-TW.json`	The locale updates date, weekday, file-selection, row, view, navigation, accessibility, scrolling, selection, and zoom translations. Terminology changes include「週」,「列」, and「檢視」.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: Minimal · previous review 0936f

This updates Traditional Chinese interface wording while preserving the corrected date, confirmation, filtering, and string-matching terminology. No current merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the main change: updating zh-TW localization wording.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: `b469041b-c8d0-4de2-b6d0-08485994e50a`

📥 Commits

Reviewing files that changed from the base of the PR and between `9b8f6db` and `63510ec`.

📒 Files selected for processing (1)

`packages/optimus-ui-locale/src/zh-TW.json`

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.

feat(i18n): change wording for zh-TW

fb64907

vercel Bot temporarily deployed to Preview August 2, 2026 04:46 Inactive

geromegrignon requested a lite review from Copilot August 4, 2026 09:46

Copilot started reviewing on behalf of geromegrignon August 4, 2026 09:46

View session

Copilot AI reviewed Aug 4, 2026

View reviewed changes

Merge branch 'openng-org:main' into main

f71e243

vercel Bot temporarily deployed to Preview August 7, 2026 14:19 Inactive

Merge branch 'openng-org:main' into main

ed04d08

vercel Bot temporarily deployed to Preview – optimus-ui August 19, 2026 10:40 Inactive

vercel Bot temporarily deployed to Preview – next-optimus-ui August 19, 2026 10:40 Inactive

Merge branch 'openng-org:main' into main

63510ec

vercel Bot temporarily deployed to Preview – optimus-ui September 3, 2026 12:17 Inactive

Merge branch 'openng-org:main' into main

0936f2c

vercel Bot temporarily deployed to Preview – optimus-ui October 17, 2026 11:50 Inactive

Merge branch 'openng-org:main' into main

801e39a

vercel Bot temporarily deployed to Preview – optimus-ui November 11, 2026 06:56 Inactive

Navigation Menu

Repository navigation

feat(i18n): change wording for zh-TW - #1424

feat(i18n): change wording for zh-TW#1424
yrctw wants to merge 8 commits into
openng-org:mainfrom
yrctw:main

yrctw commented Aug 2, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

vercel Bot commented Aug 2, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

yrctw Aug 4, 2026

Uh oh!

vercel Bot commented Aug 4, 2026

Uh oh!

geromegrignon commented Aug 4, 2026 •

edited

Loading

Uh oh!

yrctw commented Aug 4, 2026

Uh oh!

coderabbitai Bot commented Sep 3, 2026 •

edited

Loading

Review skipped

Uh oh!

This branch was previously deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

yrctw commented Aug 2, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Summary by CodeRabbit

Uh oh!

vercel Bot commented Aug 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

yrctw Aug 4, 2026

Choose a reason for hiding this comment

Uh oh!

vercel Bot commented Aug 4, 2026

Uh oh!

geromegrignon commented Aug 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yrctw commented Aug 4, 2026

Uh oh!

coderabbitai Bot commented Sep 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

This branch was previously deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

yrctw commented Aug 2, 2026 •

edited by coderabbitai Bot

Loading

vercel Bot commented Aug 2, 2026 •

edited

Loading

geromegrignon commented Aug 4, 2026 •

edited

Loading

coderabbitai Bot commented Sep 3, 2026 •

edited

Loading