Skip to content

8388284: [s390] resolve_jobject uses wrong branch condition after tmll #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Harshit470250 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

8388284: [s390] resolve_jobject uses wrong branch condition after tmll #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/hotspot/cpu/s390/gc/shared/barrierSetAssembler_s390.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,15 +116,15 @@ void BarrierSetAssembler::resolve_jobject(MacroAssembler* masm, Register value,
__ z_bre(done); // Use null result as-is.

__ z_tmll(value, JNIHandles::tag_mask);
__ z_btrue(tagged); // not zero
__ branch_optimized(Assembler::bcondNotAllZero, tagged); // not zero

// Resolve Local handle
__ access_load_at(T_OBJECT, IN_NATIVE | AS_RAW, Address(value, 0), value, tmp1, tmp2);
__ z_bru(verify);

__ bind(tagged);
__ testbit(value, exact_log2(JNIHandles::TypeTag::weak_global)); // test for weak tag
__ z_btrue(weak_tag);
__ branch_optimized(Assembler::bcondNotAllZero, weak_tag);

// resolve global handle
__ access_load_at(T_OBJECT, IN_NATIVE, Address(value, -JNIHandles::TypeTag::global), value, tmp1, tmp2);
Expand Down