Skip to content

8286300: Port JEP 425 to S390X#16

Closed
offamitkumar wants to merge 2 commits into
openjdk:masterfrom
offamitkumar:backport-offamitkumar-d425cbe2-master
Closed

8286300: Port JEP 425 to S390X#16
offamitkumar wants to merge 2 commits into
openjdk:masterfrom
offamitkumar:backport-offamitkumar-d425cbe2-master

Conversation

@offamitkumar

@offamitkumar offamitkumar commented Jul 11, 2026

Copy link
Copy Markdown
Member

This is back port for s390x loom and JEP 491 port.

There was only one merge conflict in frame_s390.hpp file other than that it was clean.

Ran tier1 test with fastdebug-vm and results are clean.



Progress

  • Change must not contain extraneous whitespace
  • JDK-8335163 needs maintainer approval
  • Commit message must refer to an issue
  • JDK-8286300 needs maintainer approval
  • JDK-8377034 needs maintainer approval
  • JDK-8380035 needs maintainer approval

Issues

  • JDK-8286300: Port JEP 425 to S390X (Enhancement - P4 - Approved)
  • JDK-8377034: Enable full JSR166TestCase.java test for s390x (Bug - P4 - Approved)
  • JDK-8380035: compiler/intrinsics/TestReturnOopSetForJFRWriteCheckpoint.java crashes on s390x (Bug - P4 - Approved)
  • JDK-8335163: [s390x] test failure - PrintClasses.java (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk27u.git pull/16/head:pull/16
$ git checkout pull/16

Update a local copy of the PR:
$ git checkout pull/16
$ git pull https://git.openjdk.org/jdk27u.git pull/16/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 16

View PR using the GUI difftool:
$ git pr show -t 16

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk27u/pull/16.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented Jul 11, 2026

Copy link
Copy Markdown

👋 Welcome back amitkumar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Jul 11, 2026

Copy link
Copy Markdown

@offamitkumar This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8286300: Port JEP 425 to S390X
8377034: Enable full JSR166TestCase.java test for s390x
8380035: compiler/intrinsics/TestReturnOopSetForJFRWriteCheckpoint.java crashes on s390x
8335163: [s390x] test failure - PrintClasses.java

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 40 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk Bot changed the title Backport d425cbe2f0df08aacd9f5093a758455309ab0cf5 8286300: Port JEP 425 to S390X Jul 11, 2026
@openjdk

openjdk Bot commented Jul 11, 2026

Copy link
Copy Markdown

This backport pull request has now been updated with issues from the original commit.

@openjdk openjdk Bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jul 11, 2026
@openjdk

openjdk Bot commented Jul 11, 2026

Copy link
Copy Markdown

⚠️ @offamitkumar This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk Bot added the rfr Pull request is ready for review label Jul 11, 2026
@mlbridge

mlbridge Bot commented Jul 11, 2026

Copy link
Copy Markdown

Webrevs

@offamitkumar

Copy link
Copy Markdown
Member Author

/approval request Loom are JEP 491 are ported on JDK 28 for s390x. We are pushing the back port for JDK 27 releases as well as JDK 28 will be released by next year. Only s390x related code is affected and other architectures are unaffected. tier1 tests with fastdebug-vm are tested on s390x machine and no new failure appeared.

@openjdk

openjdk Bot commented Jul 11, 2026

Copy link
Copy Markdown

@offamitkumar
8286300: The approval request has been created successfully.
8377034: The approval request has been created successfully.
8380035: The approval request has been created successfully.
8335163: The approval request has been created successfully.

@openjdk openjdk Bot added the approval Requires approval; will be removed when approval is received label Jul 11, 2026
@openjdk openjdk Bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Jul 20, 2026
@offamitkumar

Copy link
Copy Markdown
Member Author

/integrate

@openjdk

openjdk Bot commented Jul 21, 2026

Copy link
Copy Markdown

Going to push as commit d274f4e.
Since your change was applied there have been 40 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk Bot added the integrated Pull request has been integrated label Jul 21, 2026
@openjdk openjdk Bot closed this Jul 21, 2026
@openjdk openjdk Bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 21, 2026
@openjdk

openjdk Bot commented Jul 21, 2026

Copy link
Copy Markdown

@offamitkumar Pushed as commit d274f4e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant