Skip to content

8381868: Upgrade to JLine 4.0.12#30767

Open
lahodaj wants to merge 6 commits intoopenjdk:masterfrom
lahodaj:JDK-8381868
Open

8381868: Upgrade to JLine 4.0.12#30767
lahodaj wants to merge 6 commits intoopenjdk:masterfrom
lahodaj:JDK-8381868

Conversation

@lahodaj
Copy link
Copy Markdown
Contributor

@lahodaj lahodaj commented Apr 16, 2026

This upgrades the JLine embedded in the JDK to JLine 4.0.12.

The upgrade as such was not very difficult, but for historical reasons was done in two steps: I first upgraded to 4.0.9 using a usual process of taking a diff between existing master and the corresponding JLine (3.29.0 in this case), then replacing it with unmodified new version of JLine and re-applying the patch. The I upgraded from 4.0.9 to 4.0.12 by applying just the relevant differences between these two versions.

Other important notes:

To potentially help with the review, this is the patch between JLine 3.29.0 and master:
https://cr.openjdk.org/~jlahoda/8381868/jline-patch-3.29.0-2.diff

this is the patch between JLine 4.0.12 and the code proposed in this PR:
https://cr.openjdk.org/~jlahoda/8381868/jline-patch-4.0.12.diff

and this is a meta-diff between these two diffs:
https://cr.openjdk.org/~jlahoda/8381868/diff-of-diffs-3.29.0-4.0.12.diff

the meta diff is not straightforward to read, but I went through it, and it seems OK to me.



Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30767/head:pull/30767
$ git checkout pull/30767

Update a local copy of the PR:
$ git checkout pull/30767
$ git pull https://git.openjdk.org/jdk.git pull/30767/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 30767

View PR using the GUI difftool:
$ git pr show -t 30767

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30767.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper Bot commented Apr 16, 2026

👋 Welcome back jlahoda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 16, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot added core-libs core-libs-dev@openjdk.org compiler compiler-dev@openjdk.org labels Apr 16, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 16, 2026

@lahodaj The following labels will be automatically applied to this pull request:

  • compiler
  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk Bot added the rfr Pull request is ready for review label Apr 16, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge Bot commented Apr 16, 2026

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

compiler compiler-dev@openjdk.org core-libs core-libs-dev@openjdk.org rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant