Skip to content

Test aot agent retransform#30766

Draft
adinn wants to merge 3 commits intoopenjdk:masterfrom
adinn:test_aot_agent_retransform
Draft

Test aot agent retransform#30766
adinn wants to merge 3 commits intoopenjdk:masterfrom
adinn:test_aot_agent_retransform

Conversation

@adinn
Copy link
Copy Markdown
Contributor

@adinn adinn commented Apr 16, 2026

This test checks whether compiled training data might be included in an AOT cache that was derived from inlined code that got transformed.

Specifically, the test executes multiple calls to a method ShouldNotBeTransformed::doWork() which calls out to ShouldBeTransformed::doWork(int) to do some actual computation.

ShouldBeTransformed is then transformed so that method ShouldBeTransformed::doWork(int) simply returns its argument.

The calls to ShouldNotBeTransformed::doWork() are rerun, this time exercising the simplified version of ShouldBeTransformed::doWork(int).

The tests includes checks to verify that ShouldNotBeTransformed::doWork() is compiled during the training run and that ShouldBeTransformed::doWork(int) inlined.

In the assembly run the test enables printing of training data. The test fails if it detects the presence of compile method training data for ShouldNotBeTransformed::doWork().



Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30766/head:pull/30766
$ git checkout pull/30766

Update a local copy of the PR:
$ git checkout pull/30766
$ git pull https://git.openjdk.org/jdk.git pull/30766/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 30766

View PR using the GUI difftool:
$ git pr show -t 30766

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30766.diff

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper Bot commented Apr 16, 2026

👋 Welcome back adinn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 16, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Apr 16, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 16, 2026

@adinn The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@vnkozlov
Copy link
Copy Markdown
Contributor

vnkozlov commented Apr 16, 2026

@adinn what PrintCompilation + PrintInlining output shows for these 2 methods during training and assembly phases?

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 16, 2026

The total number of required reviews for this PR has been set to 2 based on the presence of this label: hotspot-runtime. This can be overridden with the /reviewers command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-runtime hotspot-runtime-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

2 participants