Skip to content

8382242: JFR: Metadata reconstruction invalidates ConstantMap for java.lang.String#30760

Closed
mgronlun wants to merge 4 commits intoopenjdk:masterfrom
mgronlun:8382242
Closed

8382242: JFR: Metadata reconstruction invalidates ConstantMap for java.lang.String#30760
mgronlun wants to merge 4 commits intoopenjdk:masterfrom
mgronlun:8382242

Conversation

@mgronlun
Copy link
Copy Markdown

@mgronlun mgronlun commented Apr 16, 2026

Greetings,

JFR Metadata reconstruction invalidates the existing ConstantMap for java.lang.String.

The effect of this is that JFR StringPool data is discarded, and so subsequent references from events to strings supposed to exist in the string pool, via string id lookup, fail (return null).

The existing ConstantLookup for java.lang.String should be reused when creating a new StringParser.

Testing: jdk_jfr

Thanks
Markus



Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8382242: JFR: Metadata reconstruction invalidates ConstantMap for java.lang.String (Bug - P2)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30760/head:pull/30760
$ git checkout pull/30760

Update a local copy of the PR:
$ git checkout pull/30760
$ git pull https://git.openjdk.org/jdk.git pull/30760/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 30760

View PR using the GUI difftool:
$ git pr show -t 30760

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30760.diff

Using Webrev

Link to Webrev Comment

mgronlun and others added 2 commits April 15, 2026 18:23
Co-authored-by: André Rouél <andre.rouel@gmail.com>
Co-authored-by: André Rouél <andre.rouel@gmail.com>
@bridgekeeper
Copy link
Copy Markdown

bridgekeeper Bot commented Apr 16, 2026

👋 Welcome back mgronlun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 16, 2026

@mgronlun This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8382242: JFR: Metadata reconstruction invalidates ConstantMap for java.lang.String

Reviewed-by: egahlin

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 85 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk Bot added the hotspot-jfr hotspot-jfr-dev@openjdk.org label Apr 16, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 16, 2026

@mgronlun The following label will be automatically applied to this pull request:

  • hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk Bot added the rfr Pull request is ready for review label Apr 16, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge Bot commented Apr 16, 2026

Webrevs

mgronlun and others added 2 commits April 16, 2026 15:52
Co-authored-by: André Rouél <andre.rouel@gmail.com>
Co-authored-by: André Rouél <andre.rouel@gmail.com>
@openjdk openjdk Bot added the ready Pull request is ready to be integrated label Apr 16, 2026
Copy link
Copy Markdown

@arouel arouel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mgronlun thank you for proposing a patch

@mgronlun
Copy link
Copy Markdown
Author

Thank you @egahlin for your review and @arouel for contributing.

@mgronlun
Copy link
Copy Markdown
Author

/integrate

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 17, 2026

Going to push as commit ca64301.
Since your change was applied there have been 101 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk Bot added the integrated Pull request has been integrated label Apr 17, 2026
@openjdk openjdk Bot closed this Apr 17, 2026
@openjdk openjdk Bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 17, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 17, 2026

@mgronlun Pushed as commit ca64301.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mgronlun
Copy link
Copy Markdown
Author

/backport :jdk26

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 22, 2026

@mgronlun the backport was successfully created on the branch backport-mgronlun-ca643010-jdk26 in my personal fork of openjdk/jdk. To create a pull request with this backport targeting openjdk/jdk:jdk26, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit ca643010 from the openjdk/jdk repository.

The commit being backported was authored by Markus Grönlund on 17 Apr 2026 and was reviewed by Erik Gahlin.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk:

$ git fetch https://github.com/openjdk-bots/jdk.git backport-mgronlun-ca643010-jdk26:backport-mgronlun-ca643010-jdk26
$ git checkout backport-mgronlun-ca643010-jdk26
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk.git backport-mgronlun-ca643010-jdk26

@mgronlun
Copy link
Copy Markdown
Author

/backport :jdk26u

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 22, 2026

@mgronlun The target branch jdk26u does not exist
List of valid branches: master, jdk26, jdk25, jdk24, jdk23.

@mgronlun
Copy link
Copy Markdown
Author

/backport jdk26u

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 22, 2026

@mgronlun the backport was successfully created on the branch backport-mgronlun-ca643010-master in my personal fork of openjdk/jdk26u. To create a pull request with this backport targeting openjdk/jdk26u:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit ca643010 from the openjdk/jdk repository.

The commit being backported was authored by Markus Grönlund on 17 Apr 2026 and was reviewed by Erik Gahlin.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk26u:

$ git fetch https://github.com/openjdk-bots/jdk26u.git backport-mgronlun-ca643010-master:backport-mgronlun-ca643010-master
$ git checkout backport-mgronlun-ca643010-master
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk26u.git backport-mgronlun-ca643010-master

⚠️ @mgronlun You are not yet a collaborator in my fork openjdk-bots/jdk26u. An invite will be sent out and you need to accept it before you can proceed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-jfr hotspot-jfr-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants