Skip to content

8370656: Re-examine use of InterruptedIOException in sun.security.ssl code#30753

Closed
artur-oracle wants to merge 9 commits intoopenjdk:masterfrom
artur-oracle:JDK-8370656
Closed

8370656: Re-examine use of InterruptedIOException in sun.security.ssl code#30753
artur-oracle wants to merge 9 commits intoopenjdk:masterfrom
artur-oracle:JDK-8370656

Conversation

@artur-oracle
Copy link
Copy Markdown
Member

@artur-oracle artur-oracle commented Apr 15, 2026

InterruptedIOException is being deprecated, replace it with SocketTimeoutException in SSL code.



Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8370656: Re-examine use of InterruptedIOException in sun.security.ssl code (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30753/head:pull/30753
$ git checkout pull/30753

Update a local copy of the PR:
$ git checkout pull/30753
$ git pull https://git.openjdk.org/jdk.git pull/30753/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 30753

View PR using the GUI difftool:
$ git pr show -t 30753

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30753.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper Bot commented Apr 15, 2026

👋 Welcome back abarashev! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 15, 2026

@artur-oracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8370656: Re-examine use of InterruptedIOException in sun.security.ssl code

Reviewed-by: weijun, alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 373 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk Bot added the security security-dev@openjdk.org label Apr 15, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 15, 2026

@artur-oracle The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk Bot added the rfr Pull request is ready for review label Apr 15, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge Bot commented Apr 15, 2026

Comment thread src/java.base/share/classes/sun/security/ssl/SSLSocketImpl.java Outdated
Comment thread test/jdk/sun/security/ssl/SSLSocketImpl/ClientTimeout.java Outdated
Comment thread src/java.base/share/classes/sun/security/ssl/SSLSocketImpl.java Outdated
Copy link
Copy Markdown
Contributor

@AlanBateman AlanBateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you will run tier1 + tier2.

@artur-oracle
Copy link
Copy Markdown
Member Author

I assume you will run tier1 + tier2.

It's already running, thanks!

@openjdk openjdk Bot added the ready Pull request is ready to be integrated label Apr 16, 2026
@openjdk openjdk Bot removed the ready Pull request is ready to be integrated label Apr 16, 2026
@openjdk openjdk Bot added the ready Pull request is ready to be integrated label Apr 17, 2026
@openjdk openjdk Bot removed the ready Pull request is ready to be integrated label Apr 17, 2026
@openjdk openjdk Bot added the ready Pull request is ready to be integrated label Apr 17, 2026
@artur-oracle
Copy link
Copy Markdown
Member Author

/integrate

@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 17, 2026

Going to push as commit 0a8dbed.
Since your change was applied there have been 373 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk Bot added the integrated Pull request has been integrated label Apr 17, 2026
@openjdk openjdk Bot closed this Apr 17, 2026
@openjdk openjdk Bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 17, 2026
@openjdk
Copy link
Copy Markdown

openjdk Bot commented Apr 17, 2026

@artur-oracle Pushed as commit 0a8dbed.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated security security-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

3 participants