8382277: Shenandoah: Improve mutator runtime entry points#30750
Open
shipilev wants to merge 3 commits intoopenjdk:masterfrom
Open
8382277: Shenandoah: Improve mutator runtime entry points#30750shipilev wants to merge 3 commits intoopenjdk:masterfrom
shipilev wants to merge 3 commits intoopenjdk:masterfrom
Conversation
|
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
|
@shipilev This change is no longer ready for integration - check the PR body for details. |
Webrevs
|
rkennke
approved these changes
Apr 16, 2026
Contributor
rkennke
left a comment
There was a problem hiding this comment.
This is a nice improvement! Just one small question. No need for another review, if you choose to change it.
kdnilsen
approved these changes
Apr 16, 2026
Contributor
kdnilsen
left a comment
There was a problem hiding this comment.
Thanks for all your work on these barrier improvements.
|
The total number of required reviews for this PR has been set to 2 based on the presence of this label: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a separate part of Shenandoah LBE work. On some workloads, the LRB-weak path is very hot, and little optimizations are paying off there.
Currently, we call into load_reference_barrier_mutator for strong loads, and to "normal" load_reference_barrier for weak/phantom loads. This means we are risking two things: a) a performance penalty if compiler does not inline through the
Decoratorvalue; b) exposing to interaction with JVMTI/JFR that*forwardee_mutatoris protecting us from.Additional testing:
hotspot_gc_shenandoahProgress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30750/head:pull/30750$ git checkout pull/30750Update a local copy of the PR:
$ git checkout pull/30750$ git pull https://git.openjdk.org/jdk.git pull/30750/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 30750View PR using the GUI difftool:
$ git pr show -t 30750Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30750.diff
Using Webrev
Link to Webrev Comment