Skip to content

Fix UDP receiver failing to reflect bound state #7684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nirvn wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −1
Open

Fix UDP receiver failing to reflect bound state #7684

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/core/positioning/udpreceiver.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,8 @@ void UdpReceiver::handleStateChanged( QAbstractSocket::SocketState state )
case QAbstractSocket::ListeningState:
break;
}

setSocketState( state );
}

void UdpReceiver::handleError( QAbstractSocket::SocketError error )
Expand Down
5 changes: 4 additions & 1 deletion test/qml/tst_positioning.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,7 @@ TestCase {
coordinateTransformer.verticalGrid = '';
// wait a few seconds so positioning can catch some NMEA strings
wait(2500);
compare(positioning.deviceSocketState, QAbstractSocket.ConnectedState);
compare(Math.floor(positioning.positionInformation.latitude), 46);
compare(Math.floor(positioning.positionInformation.longitude), 9);
compare(Math.floor(positioning.positionInformation.elevation / 10), 110);
Expand All @@ -166,9 +167,10 @@ TestCase {
coordinateTransformer.verticalGrid = '';

// wait a few seconds so positioning can catch some NMEA strings
wait(1000);
compare(positioning.deviceSocketState, QAbstractSocket.BoundState);
let compared = false;
for (let i = 0; i < 10; i++) {
wait(500);
if (positioning.positionInformation.qualityDescription === "Float RTK + IMU") {
compare(positioning.positionInformation.qualityDescription, "Float RTK + IMU");
compare(positioning.positionInformation.imuCorrection, true);
Expand All @@ -179,6 +181,7 @@ TestCase {
compared = true;
break;
}
wait(500);
}
compare(compared, true);
}
Expand Down
Loading