Dramatic optimization of the feature form and height binding loop fix#7679
Open
nirvn wants to merge 4 commits into
Open
Dramatic optimization of the feature form and height binding loop fix#7679nirvn wants to merge 4 commits into
nirvn wants to merge 4 commits into
Conversation
…ation for multi tab forms
Collaborator
🍎 MacOS DMG universal buildsDownload a MacOS DMG universal build of this PR for testing. 📱 Android buildsDownload an Android arm64 build of this PR for testing. Other Android architectures🪟 Windows buildsDownload a Windows build of this PR for testing and for arm64. (Built from commit 0c1ac91) 🐧 Linux AppImage buildsDownload a Linux AppImage build of this PR for testing. |
nirvn
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a long-time UI freeze when handling complex feature form containing multiple tabs. A good example of that is the sample wasterwater management project.
I was looking at a different optimization, namely the DelegateChooser (a nice gift from recent Qt versions), but ended up also adding lazy load on the main tab swipeview.
There's also a feature form height binding loop fix in there (line 576).
To feel the difference, import this project (http://qfield.org/sample-projects/wastewater.zip), open the sidebar and see the micro freezes when switching from one layer to another using a QField build other than this PR, then try this one :)