QfPaneDrawer component shared by the featurelistform and bookmarklist drawers#7669
Open
kaustuvpokharel wants to merge 3 commits into
Open
QfPaneDrawer component shared by the featurelistform and bookmarklist drawers#7669kaustuvpokharel wants to merge 3 commits into
kaustuvpokharel wants to merge 3 commits into
Conversation
Collaborator
🍎 MacOS DMG universal buildsDownload a MacOS DMG universal build of this PR for testing. 📱 Android buildsDownload an Android arm64 build of this PR for testing. Other Android architectures🪟 Windows buildsDownload a Windows build of this PR for testing and for arm64. (Built from commit 50afd45) 🐧 Linux AppImage buildsDownload a Linux AppImage build of this PR for testing. |
nirvn
reviewed
Jul 4, 2026
Comment on lines
+13
to
+16
| property real dragHeightAdjustment: 0 | ||
| property real dragWidthAdjustment: 0 | ||
| property real lastWidth | ||
| property real lastHeight |
Member
There was a problem hiding this comment.
Can we avoid exposing these internal properties at the root item level?
We can use a
QtObject {
id: props
}
object in there.
| Pane { | ||
| id: paneDrawer | ||
|
|
||
| property bool isVertical: parent.width < parent.height || parent.width < 300 |
| * \ingroup qml | ||
| */ | ||
| Pane { | ||
| id: paneDrawer |
Member
There was a problem hiding this comment.
While we're here and cleaning things up, please add // comments to the properties that have no comment yet.
Also, use //! instead of // , that will help us getting a better documentation on api.qfield.org.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The featurelistform and bookmark listdrawer had duplicated pane sizing, drag-to-resize, fullscreen and resize-animation logic. This extracts that into a shared QfPaneDrawer and migrates both onto it
Each components keeps its own header, content and behaviour, configuring the shell via contentVisible, minContentHeight, headerHeight and freezeKey, and reacting to collapsed() for below-minimum drags. NavigationBar is unchanged, hence no behavioural change intended for either drawer