Added qml tests for the vertex editor geometry tool#7579
Open
kaustuvpokharel wants to merge 5 commits into
Open
Added qml tests for the vertex editor geometry tool#7579kaustuvpokharel wants to merge 5 commits into
kaustuvpokharel wants to merge 5 commits into
Conversation
Collaborator
🍎 MacOS DMG universal buildsDownload a MacOS DMG universal build of this PR for testing. 🪟 Windows buildsDownload a Windows build of this PR for testing and for arm64. (Built from commit e08efc1) 🐧 Linux AppImage buildsDownload a Linux AppImage build of this PR for testing. 📱 Android buildsDownload an Android arm64 build of this PR for testing. Other Android architectures |
nirvn
reviewed
Jun 19, 2026
nirvn
reviewed
Jun 26, 2026
nirvn
reviewed
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr adds a qml test file for the vertex editor tool. The vertex model itself is already covered in test_vertexmodel.cpp, so this does not retest that. It focuses on the tool layer around it: init wiring, applyChanges and the autoSave branch, cancel, remove, and undo.
The tool reads a few objects from its parent scope in the app (qfieldSettings, coordinateLocator, etc). I provide them in the test the same way tst_featureForm.qml does, as plain in-scope items. mapSettings is a real MapSettings set to the Fields layer CRS so the vertex model transform is a no-op. Tests run against the existing Fields (polygon) and Tracks (line) features in test_bees.qgz, and never commit, the edits go to the layer edit buffer and are rolled back after each test so the shared data stays clean.