Adds Northwest Passage map (using new additionalNations feature)#3920
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
WalkthroughAdds the "Northwest Passage" map: metadata files (info + manifest), game enum/category entry, English translation, map-generator registration, and playlist frequency weighting. ChangesNorthwest Passage Map Addition
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@map-generator/assets/maps/northwestpassage/info.json`:
- Around line 100-104: The Ulukhaktok nation object has its "flag" property on a
separate line breaking the file's formatting; locate the object with "name":
"Ulukhaktok" and move the "flag": "northwestterritories" entry so it matches the
other nation entries' style (place the flag property on the same line/position
as the closing brace/comma used elsewhere) to restore consistent JSON
formatting.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: c76cce9f-95ba-4a97-bdd3-6e310e39fea3
⛔ Files ignored due to path filters (4)
map-generator/assets/maps/northwestpassage/image.pngis excluded by!**/*.pngresources/maps/northwestpassage/map.binis excluded by!**/*.binresources/maps/northwestpassage/map16x.binis excluded by!**/*.binresources/maps/northwestpassage/map4x.binis excluded by!**/*.bin
📒 Files selected for processing (7)
map-generator/assets/maps/northwestpassage/info.jsonmap-generator/main.goresources/lang/en.jsonresources/maps/northwestpassage/manifest.jsonresources/maps/northwestpassage/thumbnail.webpsrc/core/game/Game.tssrc/server/MapPlaylist.ts
Description:
Adds map "Northwest Passage", map of the Canadian Arctic Archipelago , Greenland and surroundings. "Northwest Passage" (NWP) is the sea lane between the Atlantic and Pacific oceans (https://en.wikipedia.org/wiki/Northwest_Passage) .
21 default nations, based on the towns of the region.
This map uses the brand new additionalNations feature made by FloPinguin #3902 . Adds 39 extra nations for a total of 60 nations (so that in gamemodes like Humans vs Nations all the nations have names of real places)
Comparison:
Terrain source from OpenTopography, already credited in CREDITS.md
Please complete the following:
Please put your Discord username so you can be contacted if a bug or regression is found:
tri.star1011