Skip to content

Adds Northwest Passage map (using new additionalNations feature)#3920

Merged
evanpelle merged 2 commits into
openfrontio:mainfrom
RickD004:northwestpassage
May 15, 2026
Merged

Adds Northwest Passage map (using new additionalNations feature)#3920
evanpelle merged 2 commits into
openfrontio:mainfrom
RickD004:northwestpassage

Conversation

@RickD004
Copy link
Copy Markdown
Contributor

@RickD004 RickD004 commented May 14, 2026

Description:

Adds map "Northwest Passage", map of the Canadian Arctic Archipelago , Greenland and surroundings. "Northwest Passage" (NWP) is the sea lane between the Atlantic and Pacific oceans (https://en.wikipedia.org/wiki/Northwest_Passage) .

21 default nations, based on the towns of the region.

This map uses the brand new additionalNations feature made by FloPinguin #3902 . Adds 39 extra nations for a total of 60 nations (so that in gamemodes like Humans vs Nations all the nations have names of real places)

Comparison:

  • Map with default nations
  • Map with extra named nations, tested by raising the number of nations in Solo
image image

Terrain source from OpenTopography, already credited in CREDITS.md

Please complete the following:

  • I have added screenshots for all UI updates
  • I process any text displayed to the user through translateText() and I've added it to the en.json file
  • I have added relevant tests to the test directory
  • I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced

Please put your Discord username so you can be contacted if a bug or regression is found:

tri.star1011

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 14, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 55e34e71-4249-48fe-a749-1e92a9dd77d1

📥 Commits

Reviewing files that changed from the base of the PR and between 6ee4855 and 6304180.

📒 Files selected for processing (1)
  • map-generator/assets/maps/northwestpassage/info.json
✅ Files skipped from review due to trivial changes (1)
  • map-generator/assets/maps/northwestpassage/info.json

Walkthrough

Adds the "Northwest Passage" map: metadata files (info + manifest), game enum/category entry, English translation, map-generator registration, and playlist frequency weighting.

Changes

Northwest Passage Map Addition

Layer / File(s) Summary
Map metadata definition
map-generator/assets/maps/northwestpassage/info.json, resources/maps/northwestpassage/manifest.json
Map data files define name, nations, additionalNations with coordinates and flags, plus multi-resolution tile metadata (map, map16x, map4x).
Game type system and localization
src/core/game/Game.ts, resources/lang/en.json
GameMapType gains NorthwestPassage, it's added to mapCategories.regional, and map.northwestpassage English label is added.
Map generator and playlist registration
map-generator/main.go, src/server/MapPlaylist.ts
"northwestpassage" added to the map-generator maps slice and GameMapName.NorthwestPassage assigned frequency 5 in playlist FREQUENCY.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🗺️ North winds whisper on a brand new chart,
Flags and coords placed like a work of art,
Types and locales, generator sings,
Playlists favor journeys the new map brings,
Set sail north—adventure starts!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: adding the Northwest Passage map with the additionalNations feature.
Description check ✅ Passed The description is well-related to the changeset, providing context about the map, its features, screenshots, and testing confirmation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@map-generator/assets/maps/northwestpassage/info.json`:
- Around line 100-104: The Ulukhaktok nation object has its "flag" property on a
separate line breaking the file's formatting; locate the object with "name":
"Ulukhaktok" and move the "flag": "northwestterritories" entry so it matches the
other nation entries' style (place the flag property on the same line/position
as the closing brace/comma used elsewhere) to restore consistent JSON
formatting.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c76cce9f-95ba-4a97-bdd3-6e310e39fea3

📥 Commits

Reviewing files that changed from the base of the PR and between 5e7f154 and 6ee4855.

⛔ Files ignored due to path filters (4)
  • map-generator/assets/maps/northwestpassage/image.png is excluded by !**/*.png
  • resources/maps/northwestpassage/map.bin is excluded by !**/*.bin
  • resources/maps/northwestpassage/map16x.bin is excluded by !**/*.bin
  • resources/maps/northwestpassage/map4x.bin is excluded by !**/*.bin
📒 Files selected for processing (7)
  • map-generator/assets/maps/northwestpassage/info.json
  • map-generator/main.go
  • resources/lang/en.json
  • resources/maps/northwestpassage/manifest.json
  • resources/maps/northwestpassage/thumbnail.webp
  • src/core/game/Game.ts
  • src/server/MapPlaylist.ts

Comment thread map-generator/assets/maps/northwestpassage/info.json
@github-project-automation github-project-automation Bot moved this from Triage to Development in OpenFront Release Management May 14, 2026
@github-project-automation github-project-automation Bot moved this from Development to Final Review in OpenFront Release Management May 15, 2026
@evanpelle evanpelle added this to the v32 milestone May 15, 2026
@evanpelle evanpelle merged commit 7359e2b into openfrontio:main May 15, 2026
11 of 12 checks passed
@github-project-automation github-project-automation Bot moved this from Final Review to Complete in OpenFront Release Management May 15, 2026
@RickD004 RickD004 deleted the northwestpassage branch May 15, 2026 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

2 participants