Skip to content

Fix comparison operator for distance checks #3790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TKTK123456 wants to merge 5 commits into
base: main
Choose a base branch
from
+2 −2
Open

Fix comparison operator for distance checks #3790

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
81c2764
Fix comparison operator for distance checks
TKTK123456 Apr 28, 2026
ef04cb9
Merge branch 'main' into structureMinDist-fix
TKTK123456 Apr 28, 2026
5c162ab
Merge branch 'openfrontio:main' into structureMinDist-fix
TKTK123456 May 1, 2026
6a8aa89
Merge branch 'openfrontio:main' into structureMinDist-fix
TKTK123456 May 2, 2026
92d6ad8
Merge branch 'openfrontio:main' into structureMinDist-fix
TKTK123456 May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/core/game/RailNetworkImpl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,7 @@ export class RailNetworkImpl implements RailNetwork {
for (const neighbor of neighbors) {
// Limit to the closest 5 stations to avoid running too many pathfinding calls.
if (paths.length >= 5) break;
if (neighbor.distSquared <= minRangeSquared) continue;
if (neighbor.distSquared < minRangeSquared) continue;

const neighborStation = this._stationManager.findStation(neighbor.unit);
if (!neighborStation) continue;
Expand Down Expand Up @@ -318,7 +318,7 @@ export class RailNetworkImpl implements RailNetwork {
distanceToStation === -1;
if (
connectionAvailable &&
neighbor.distSquared > this.game.config().trainStationMinRange() ** 2
neighbor.distSquared >= this.game.config().trainStationMinRange() ** 2
) {
if (this.connect(station, neighborStation)) {
neighborCluster.addStation(station);
Expand Down
Loading