fix: throw IllegalArgumentException for invalid paths in FileSystem#389
Open
MatrixNeoKozak wants to merge 1 commit into
Open
fix: throw IllegalArgumentException for invalid paths in FileSystem#389MatrixNeoKozak wants to merge 1 commit into
MatrixNeoKozak wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Corrected the
FileSystemutility methodstoFileandtoDirto throwIllegalArgumentExceptionwhen paths are invalid, instead of merely logging the error.Rationale: The previous implementation allowed invalid file system operations to proceed after logging, which could lead to unpredictable behavior and potential downstream errors when methods expected a valid File object.
Technical Impact: Improves robustness by enforcing validation and ensuring fail-fast behavior when file system operations are initialized with incorrect paths, preventing erroneous object usage.