map: show layers panel also for sampling point data#4282
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds MapLayersPanel support for Sampling Point Data layers so those points can be listed, sorted, and selected via the side panel (behind experimental features), aligning behavior with existing geo-attribute layers.
Changes:
- Sampling point GeoJSON features now include
ancestorsKeysto support MapLayersPanel labeling/sorting. - Sampling point markers now notify the panel when popups open/close (selection sync), and sampling point layers register/unregister with MapLayersPanel when active.
useFlyToPointnow returns a stableflyToPointfunction (via ref) so panel registrations don’t churn on popup-state changes; GeoAttributeDataLayer is updated accordingly.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| webapp/views/App/views/Data/MapView/SamplingPointDataLayer/useSamplingPointDataLayer.js | Adds ancestorsKeys and tracks layer active state for panel registration. |
| webapp/views/App/views/Data/MapView/SamplingPointDataLayer/SamplingPointDataMarker.js | Emits popupopen to sync panel selection with marker popups. |
| webapp/views/App/views/Data/MapView/SamplingPointDataLayer/SamplingPointDataLayer.js | Registers sampling point layers into MapLayersPanel; hooks popup open/close to selection. |
| webapp/views/App/views/Data/MapView/GeoAttributeDataLayer/GeoAttributeDataLayer.js | Gates panel registration behind experimental features; relies on stable flyToPoint from hook. |
| webapp/views/App/views/Data/MapView/common/useFlyToPoint.js | Returns a stable flyToPoint wrapper to avoid re-registering layers on popup-state changes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.