Skip to content

Map layers panel#4281

Merged
SteRiccio merged 17 commits into
masterfrom
feat/map-layers-panel
Jun 18, 2026
Merged

Map layers panel#4281
SteRiccio merged 17 commits into
masterfrom
feat/map-layers-panel

Conversation

@SteRiccio

@SteRiccio SteRiccio commented Jun 16, 2026

Copy link
Copy Markdown
Member

resolves #3657

@SteRiccio SteRiccio self-assigned this Jun 16, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a “Map layers” side panel in the Data Map view, letting users browse/select layer points (markers), sort them, and fly the map to a selected point, while keeping the Leaflet map mounted during layout changes.

Changes:

  • Added MapLayersPanel + context/provider to register active layers and drive selection/sorting.
  • Implemented resizable split layout (panel + map) and a Leaflet resize handler to keep the map sized correctly when the panel changes width.
  • Added a reusable useHorizontalResize hook and new i18n strings for the panel controls.

Reviewed changes

Copilot reviewed 21 out of 23 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
webapp/views/App/views/Data/MapView/MapView.tsx Wraps map view in panel provider; adds stable split layout + resize gutter.
webapp/views/App/views/Data/MapView/MapView.scss Adds flex layout styles for panel/gutter/map.
webapp/views/App/views/Data/MapView/MapLayersPanel/MapLayersPanelContext.tsx New context managing active layers, sort orders, selection, and visibility.
webapp/views/App/views/Data/MapView/MapLayersPanel/MapLayersPanel.tsx New MUI-based panel UI with accordions, sorting, and virtualized point list.
webapp/views/App/views/Data/MapView/MapLayersPanel/MapLayersPanel.scss Placeholder stylesheet comment for the panel.
webapp/views/App/views/Data/MapView/MapLayersPanel/index.ts Exports panel and provider.
webapp/views/App/views/Data/MapView/GeoAttributeDataLayer/useGeoAttributeDataLayer.js Clears query/points on layer removal; exposes layerInnerName.
webapp/views/App/views/Data/MapView/GeoAttributeDataLayer/GeoAttributeDataLayer.js Registers/unregisters layer in panel context; syncs selected point on popup open/close; applies panel sort order for navigation.
webapp/views/App/views/Data/MapView/GeoAttributeDataLayer/CoordinateAttributeMarker.js Emits popupopen events to sync selection with the panel.
webapp/components/MapContainer/MapContainer.js Adds ResizeObserver-based handler to invalidate Leaflet size on container resize.
webapp/components/hooks/useHorizontalResize.ts New hook for mouse/touch/keyboard horizontal resizing.
webapp/components/hooks/index.js Exports the new resize hook.
core/i18n/resources/*/dataView.js Adds translations for panel show/hide and sort controls.
package.json Bumps Yarn packageManager to 4.17.0.
.yarnrc.yml Updates yarnPath to 4.17.0.
.claude/settings.json Adds Claude tool settings (npx tsc permission).
Comments suppressed due to low confidence (2)

webapp/views/App/views/Data/MapView/MapView.tsx:193

  • GeoAttributeDataLayer no longer receives editingRecordUuid, but useGeoAttributeDataLayer still relies on it to refresh points after a record edit (see useGeoAttributeDataLayer destructuring editingRecordUuid). This likely breaks marker updates after editing a record from the map popup/modal.
    webapp/views/App/views/Data/MapView/MapView.tsx:70
  • The resize gutter uses left/right arrow keys and changes width horizontally, but aria-orientation is set to vertical. For a slider that adjusts via left/right, this should be horizontal so assistive tech announces it correctly.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread webapp/components/hooks/useHorizontalResize.ts Outdated
Comment thread webapp/components/hooks/useHorizontalResize.ts
Comment thread webapp/views/App/views/Data/MapView/MapLayersPanel/MapLayersPanel.scss Outdated
@SteRiccio SteRiccio merged commit bd81a58 into master Jun 18, 2026
6 checks passed
@SteRiccio SteRiccio deleted the feat/map-layers-panel branch June 18, 2026 20:54
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Map: show list of points in layers; allow selecting and showing them;

3 participants